MINOR: Convert connect assignment schemas to use generated protocol#9641
MINOR: Convert connect assignment schemas to use generated protocol#9641chia7712 wants to merge 13 commits intoapache:trunkfrom
Conversation
| public static final String ASSIGNMENT_KEY_NAME = "assignment"; | ||
| public static final int CONNECTOR_TASK = -1; | ||
|
|
||
| public static final short CONNECT_PROTOCOL_V0 = 0; |
There was a problem hiding this comment.
The CONNECT_PROTOCOL_V0 is only used in ConnectProtocolCompatibility.fromProtocolVersion(), I think we shouldn't depend on the version to compute ConnectProtocolCompatibility because every time we bump the version we should change the method, maybe we can add a field in the ExtendedWorkerMetadata.json to represent the corresponding ConnectProtocolCompatibility.
There was a problem hiding this comment.
I feel the version is bump only if we add new protocol (see https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java#L190).
For another, your comment inspires me that the constant field can be moved to ConnectProtocolCompatibility as it is used by ConnectProtocolCompatibility only
|
convert this patch to draft as some system tests can't pass on my local |
4 participants
as title.
Committer Checklist (excluded from commit message)