MINOR: Remove toStruct and fromStruct methods from generated protocol classes#9960
MINOR: Remove toStruct and fromStruct methods from generated protocol classes#9960ijuma merged 5 commits intoapache:trunkfrom
toStruct and fromStruct methods from generated protocol classes#9960Conversation
…ocol classes Update few classes that were still using the removed methods (including tests that are no longer required).
| @@ -188,9 +185,7 @@ public KafkaPrincipal deserialize(byte[] bytes) { | |||
| throw new SerializationException("Invalid principal data version " + version); | |||
There was a problem hiding this comment.
Could we use HIGHEST_SUPPORTED_VERSION and LOWEST_SUPPORTED_VERSION to replace origin condition ("0" and DefaultPrincipalData.SCHEMAS.length) ?
| OffsetFetchResponse oldResponse = new OffsetFetchResponse(data, version); | ||
|
|
||
| if (version <= 1) { | ||
| assertFalse(struct.hasField(ERROR_CODE)); |
There was a problem hiding this comment.
the field "ERROR_CODE" is never used.
|
|
||
| Deserializing Messages | ||
| ---------------------- | ||
| Message objects may be deserialized using the Message#read method. This method |
There was a problem hiding this comment.
There is another invalid description.
You can also deserialize a message from a Struct by calling Message#fromStruct.
The Struct will not be modified.
|
This is nice, maybe we will also remove |
|
@dengziming Looks like |
|
Hmm, we may need to keep |
|
Yes, #9766 is trying to replace Struct in |
|
JDK 11 build passed, JDK 8 and 15 had unrelated flaky failures. |
…e-allocations-lz4 * apache-github/trunk: (562 commits) MINOR: remove unused code from MessageTest (apache#9961) MINOR: Fix visibility of Log.{unflushedMessages, addSegment} methods (apache#9966) KAFKA-12229: Restore original class loader in integration tests using EmbeddedConnectCluster during shutdown (apache#9942) KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems (apache#9947) MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes (apache#9960) MINOR: Fix typo in Utils#toPositive (apache#9943) MINOR: MessageUtil: remove some deadcode (apache#9931) MINOR: Update zstd-jni to 1.4.8-2 (apache#9957) MINOR: Revert assertion in MockProducerTest (apache#9956) MINOR: Optimize assertions in unit tests (apache#9955) MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it (apache#9925) MINOR: Update to Gradle 6.8.1 (apache#9953) MINOR: A few small group coordinator cleanups (apache#9952) MINOR: Upgrade ducktape to version 0.8.1 (apache#9933) MINOR: fix record time in test shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing (apache#9948) MINOR: Restore interrupt status when closing (apache#9863) KAFKA-10357: Extract setup of repartition topics from Streams partition assignor (apache#9848) KAFKA-12212; Bump Metadata API version to remove `ClusterAuthorizedOperations` fields (KIP-700) (apache#9945) MINOR: log 2min processing summary of StreamThread loop (apache#9941) MINOR: Drop enable.metadata.quorum config (apache#9934) ...
Update few classes that were still using the removed methods (including
tests that are no longer required).
Committer Checklist (excluded from commit message)