Skip to content

MINOR: Update zstd-jni to 1.4.8-2#9957

Merged
ijuma merged 3 commits intoapache:trunkfrom
ijuma:zstd-update
Jan 25, 2021
Merged

MINOR: Update zstd-jni to 1.4.8-2#9957
ijuma merged 3 commits intoapache:trunkfrom
ijuma:zstd-update

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Jan 24, 2021

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@luben
Copy link
Copy Markdown

luben commented Jan 24, 2021

LGTM. Thanks for the fast reaction.

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Jan 24, 2021

Looks like the checkstyle import rules need to be updated, will do it later today.

@ijuma ijuma requested a review from chia7712 January 24, 2021 23:40
@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Jan 25, 2021

Tests passed with JDK 11 and 1 unrelated flaky failure for JDK 15 and 8 (both passed when retried).

Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, are you going to implement zstd buffer pool by our buffer supplier (even though #9229 is not merged)?

@luben
Copy link
Copy Markdown

luben commented Jan 25, 2021

BTW, are you going to implement zstd buffer pool by our buffer supplier (even though #9229 is not merged)?

I think it would be good next step. I looked at Kafka's BufferSupplier and there are considerable advantages: no synchronization as it looks it has pool per thread, no soft references, etc.

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Jan 25, 2021

@chia7712 I was planning to revive #9229 soon. If it's easy, I'll swap zstd and snappy to use the Kafka buffer supplier for the decompression path. The compression path will have to be handled separately (including work on the lz4 class).

@ijuma ijuma merged commit 24a2ed2 into apache:trunk Jan 25, 2021
@ijuma ijuma deleted the zstd-update branch January 25, 2021 04:21
ijuma added a commit to ijuma/kafka that referenced this pull request Jan 26, 2021
…e-allocations-lz4

* apache-github/trunk: (562 commits)
  MINOR: remove unused code from MessageTest (apache#9961)
  MINOR: Fix visibility of Log.{unflushedMessages, addSegment} methods (apache#9966)
  KAFKA-12229: Restore original class loader in integration tests using EmbeddedConnectCluster during shutdown  (apache#9942)
  KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems (apache#9947)
  MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes (apache#9960)
  MINOR: Fix typo in Utils#toPositive (apache#9943)
  MINOR: MessageUtil: remove some deadcode (apache#9931)
  MINOR: Update zstd-jni to 1.4.8-2 (apache#9957)
  MINOR: Revert assertion in MockProducerTest (apache#9956)
  MINOR: Optimize assertions in unit tests (apache#9955)
  MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it (apache#9925)
  MINOR: Update to Gradle 6.8.1 (apache#9953)
  MINOR: A few small group coordinator cleanups (apache#9952)
  MINOR: Upgrade ducktape to version 0.8.1  (apache#9933)
  MINOR: fix record time in test shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing (apache#9948)
  MINOR: Restore interrupt status when closing (apache#9863)
  KAFKA-10357: Extract setup of repartition topics from Streams partition assignor (apache#9848)
  KAFKA-12212; Bump Metadata API version to remove `ClusterAuthorizedOperations` fields (KIP-700) (apache#9945)
  MINOR: log 2min processing summary of StreamThread loop (apache#9941)
  MINOR: Drop enable.metadata.quorum config (apache#9934)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants