MINOR: Drop enable.metadata.quorum config#9934
Conversation
hachikuji
force-pushed
the
drop-enable-metadata-flag
branch
from
75f4a87 to
4bebbdf
Compare
|
@hachikuji Do we still need this PR since Colin already did one? |
There was a problem hiding this comment.
Can we call it "Early Access" instead of Alpha?
There was a problem hiding this comment.
I think I'm going to keep this as internal for now. Let's reconsider this after we have something that can actually start up.
That PR was for the KIP-500 branch, not for trunk. It also didn't refactor the "disabled" APIs concept, which I think is useful.
That seems reasonable. I guess the idea is that the broker will not include those APIs in its ApiVersionsResponse. However, the controller always will (not that clients will talk directly to the controller anyway...) |
|
@cmccabe Yeah, that's right. Let me see if I can improve this a little bit to make the intent clearer. We have some APIs which will be exposed by both the broker and the controller, so I think this should probably be a set rather than a flag. |
|
I decided to leave the controller-only flag as it is. I think there are further improvements here to make the scope of the API clearer, but the implications for compatibility are subtle enough that we should consider it separately. |
hachikuji
force-pushed
the
drop-enable-metadata-flag
branch
from
5c75787 to
50fa8e9
Compare
…e-allocations-lz4 * apache-github/trunk: (562 commits) MINOR: remove unused code from MessageTest (apache#9961) MINOR: Fix visibility of Log.{unflushedMessages, addSegment} methods (apache#9966) KAFKA-12229: Restore original class loader in integration tests using EmbeddedConnectCluster during shutdown (apache#9942) KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems (apache#9947) MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes (apache#9960) MINOR: Fix typo in Utils#toPositive (apache#9943) MINOR: MessageUtil: remove some deadcode (apache#9931) MINOR: Update zstd-jni to 1.4.8-2 (apache#9957) MINOR: Revert assertion in MockProducerTest (apache#9956) MINOR: Optimize assertions in unit tests (apache#9955) MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it (apache#9925) MINOR: Update to Gradle 6.8.1 (apache#9953) MINOR: A few small group coordinator cleanups (apache#9952) MINOR: Upgrade ducktape to version 0.8.1 (apache#9933) MINOR: fix record time in test shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing (apache#9948) MINOR: Restore interrupt status when closing (apache#9863) KAFKA-10357: Extract setup of repartition topics from Streams partition assignor (apache#9848) KAFKA-12212; Bump Metadata API version to remove `ClusterAuthorizedOperations` fields (KIP-700) (apache#9945) MINOR: log 2min processing summary of StreamThread loop (apache#9941) MINOR: Drop enable.metadata.quorum config (apache#9934) ...
4 participants
The primary purpose of this patch is to remove the internal
enable.metadata.quorumconfiguration. Instead, we rely onprocess.rolesto determine if the self-managed quorum has been enabled. As a part of this, I've done the following:ForwardingManageroptional inKafkaServerandKafkaApis. Previously we usednullif forwarding was enabled and relied on the metadata quorum check.zookeeper.connectan optional configuration ifprocess.rolesis defined.Committer Checklist (excluded from commit message)