Skip to content

MINOR: fix record time in shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing#9948

Merged
mjsax merged 1 commit intoapache:trunkfrom
wcarlson5:Minor_update_standy_test
Jan 22, 2021
Merged

MINOR: fix record time in shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing#9948
mjsax merged 1 commit intoapache:trunkfrom
wcarlson5:Minor_update_standy_test

Conversation

@wcarlson5
Copy link
Copy Markdown
Contributor

Prevents cleaner thread from occasionally deleting segments

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@wcarlson5
Copy link
Copy Markdown
Contributor Author

@mjsax I extracted the fix

@wcarlson5 wcarlson5 changed the title Minor: fix record time MINOR: fix record time Jan 21, 2021
@wcarlson5 wcarlson5 changed the title MINOR: fix record time MINOR: fix record time in shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing Jan 21, 2021
@mjsax mjsax added streams tests Test fixes (including flaky tests) labels Jan 22, 2021
Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge after Jenkins passed and cherry-pick to older branches.

@showuon
Copy link
Copy Markdown
Member

showuon commented Jan 22, 2021

LGTM! Thanks for the fix, @wcarlson5 . And all tests passed!

@mjsax mjsax merged commit 667a6b2 into apache:trunk Jan 22, 2021
@wcarlson5 wcarlson5 deleted the Minor_update_standy_test branch January 22, 2021 23:59
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jan 23, 2021

@showuon -- I just see you comment now after merging. Did not add you as reviewer in the commit message. Sorry about that.

mjsax pushed a commit that referenced this pull request Jan 23, 2021
…eckpointIsMissing (#9948)

Reviewer: Matthias J. Sax <matthias@confluent.io>
mjsax pushed a commit that referenced this pull request Jan 23, 2021
…eckpointIsMissing (#9948)

Reviewer: Matthias J. Sax <matthias@confluent.io>
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Jan 23, 2021

Merged to trunk and cherry-picked to 2.7 and 2.6 branches.

ijuma added a commit to ijuma/kafka that referenced this pull request Jan 26, 2021
…e-allocations-lz4

* apache-github/trunk: (562 commits)
  MINOR: remove unused code from MessageTest (apache#9961)
  MINOR: Fix visibility of Log.{unflushedMessages, addSegment} methods (apache#9966)
  KAFKA-12229: Restore original class loader in integration tests using EmbeddedConnectCluster during shutdown  (apache#9942)
  KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems (apache#9947)
  MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes (apache#9960)
  MINOR: Fix typo in Utils#toPositive (apache#9943)
  MINOR: MessageUtil: remove some deadcode (apache#9931)
  MINOR: Update zstd-jni to 1.4.8-2 (apache#9957)
  MINOR: Revert assertion in MockProducerTest (apache#9956)
  MINOR: Optimize assertions in unit tests (apache#9955)
  MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it (apache#9925)
  MINOR: Update to Gradle 6.8.1 (apache#9953)
  MINOR: A few small group coordinator cleanups (apache#9952)
  MINOR: Upgrade ducktape to version 0.8.1  (apache#9933)
  MINOR: fix record time in test shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing (apache#9948)
  MINOR: Restore interrupt status when closing (apache#9863)
  KAFKA-10357: Extract setup of repartition topics from Streams partition assignor (apache#9848)
  KAFKA-12212; Bump Metadata API version to remove `ClusterAuthorizedOperations` fields (KIP-700) (apache#9945)
  MINOR: log 2min processing summary of StreamThread loop (apache#9941)
  MINOR: Drop enable.metadata.quorum config (apache#9934)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants