KAFKA-12212; Bump Metadata API version to remove ClusterAuthorizedOperations fields#9945
Merged
dajac merged 2 commits intoapache:trunkfrom Jan 22, 2021
Merged
KAFKA-12212; Bump Metadata API version to remove ClusterAuthorizedOperations fields#9945dajac merged 2 commits intoapache:trunkfrom
ClusterAuthorizedOperations fields#9945dajac merged 2 commits intoapache:trunkfrom
Conversation
chia7712
reviewed
Jan 21, 2021
| @@ -1246,13 +1246,15 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| } | |||
|
|
|||
| var clusterAuthorizedOperations = Int.MinValue | |||
Member
There was a problem hiding this comment.
the default value of clusterAuthorizedOperations in auto-generated protocol is -2147483648. If the version of request is bigger than 10, does it cause error if we set Int.MinValue to clusterAuthorizedOperations of MetadataResponseData?
Member
Author
There was a problem hiding this comment.
-2147483648 is actually Int.MinValue. It would cause an error if we would write something different from the default value for versions < 8 and > 10.
Member
There was a problem hiding this comment.
Could you add the comments for that value (Int.MinValue) for dumb readers like me :)
| // | ||
| // Version 10 adds topicId. | ||
| // | ||
| // Version 11 deprecates IncludeClusterAuthorizedOperations field (KIP-700). |
Member
There was a problem hiding this comment.
How about saying this function is migrated to DescribeClusterRequest?
Member
Author
There was a problem hiding this comment.
Yeah, why not. I will add it.
Member
Author
|
@chia7712 Thanks for your comments. I have updated the PR to address them. |
rajinisivaram
approved these changes
Jan 21, 2021
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@dajac Thanks for the PR, LGTM
Member
Author
|
Failed tests are not related:
Merging to trunk. |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Jan 26, 2021
…e-allocations-lz4 * apache-github/trunk: (562 commits) MINOR: remove unused code from MessageTest (apache#9961) MINOR: Fix visibility of Log.{unflushedMessages, addSegment} methods (apache#9966) KAFKA-12229: Restore original class loader in integration tests using EmbeddedConnectCluster during shutdown (apache#9942) KAFKA-12190: Fix setting of file permissions on non-POSIX filesystems (apache#9947) MINOR: Remove `toStruct` and `fromStruct` methods from generated protocol classes (apache#9960) MINOR: Fix typo in Utils#toPositive (apache#9943) MINOR: MessageUtil: remove some deadcode (apache#9931) MINOR: Update zstd-jni to 1.4.8-2 (apache#9957) MINOR: Revert assertion in MockProducerTest (apache#9956) MINOR: Optimize assertions in unit tests (apache#9955) MINOR: Tag `RaftEventSimulationTest` as `integration` and tweak it (apache#9925) MINOR: Update to Gradle 6.8.1 (apache#9953) MINOR: A few small group coordinator cleanups (apache#9952) MINOR: Upgrade ducktape to version 0.8.1 (apache#9933) MINOR: fix record time in test shouldWipeOutStandbyStateDirectoryIfCheckpointIsMissing (apache#9948) MINOR: Restore interrupt status when closing (apache#9863) KAFKA-10357: Extract setup of repartition topics from Streams partition assignor (apache#9848) KAFKA-12212; Bump Metadata API version to remove `ClusterAuthorizedOperations` fields (KIP-700) (apache#9945) MINOR: log 2min processing summary of StreamThread loop (apache#9941) MINOR: Drop enable.metadata.quorum config (apache#9934) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the version of the Metadata API and deprecates the
IncludeClusterAuthorizedOperationsand theIncludeClusterAuthorizedOperationsfields from version 11 and onward.Committer Checklist (excluded from commit message)