KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified#9706
Merged
chia7712 merged 1 commit intoapache:trunkfrom Dec 23, 2020
Merged
Conversation
3 tasks
…oop if all partitions are verified
Member
Author
chia7712
added a commit
to chia7712/kafka
that referenced
this pull request
Dec 23, 2020
…oop if all partitions are verified (apache#9706) Reviewers: Matthias J. Sax <mjsax@apache.org>
3 tasks
chia7712
added a commit
to chia7712/kafka
that referenced
this pull request
Dec 23, 2020
…oop if all partitions are verified (apache#9706) Reviewers: Matthias J. Sax <mjsax@apache.org>
3 tasks
Member
|
@chia7712 -- thanks for getting this into 2.7 and 2.6. (Btw: there is no need to do PRs. You can also cherry-pick and push directly.) |
Member
Author
Thanks for kind reminder! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: https://issues.apache.org/jira/browse/KAFKA-10815
If we don't break it when all partitions are verified, the loop will take 10 mins ...
see https://travis-ci.com/github/apache/kafka/jobs/455103274 for related timeout
this issue is related to cb88be4
Committer Checklist (excluded from commit message)