Skip to content

KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified#9706

Merged
chia7712 merged 1 commit intoapache:trunkfrom
chia7712:KAFKA-10815
Dec 23, 2020
Merged

KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified#9706
chia7712 merged 1 commit intoapache:trunkfrom
chia7712:KAFKA-10815

Conversation

@chia7712
Copy link
Copy Markdown
Member

@chia7712 chia7712 commented Dec 7, 2020

issue: https://issues.apache.org/jira/browse/KAFKA-10815
If we don't break it when all partitions are verified, the loop will take 10 mins ...

see https://travis-ci.com/github/apache/kafka/jobs/455103274 for related timeout


2994[INFO:2020-12-06 06:06:35,755]: Triggering test 10 of 32...
2995[INFO:2020-12-06 06:06:35,765]: RunnerClient: Loading test {'directory': '/opt/kafka-dev/tests/kafkatest/tests/streams', 'file_name': 'streams_eos_test.py', 'cls_name': 'StreamsEosTest', 'method_name': 'test_rebalance_complex', 'injected_args': {'processing_guarantee': 'exactly_once'}}
2996[INFO:2020-12-06 06:06:35,771]: RunnerClient: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex.processing_guarantee=exactly_once: Setting up...
2997[INFO:2020-12-06 06:07:12,200]: RunnerClient: kafkatest.tests.streams.streams_eos_test.StreamsEosTest.test_rebalance_complex.processing_guarantee=exactly_once: Running...
2998
2999
3000No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
3001Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

this issue is related to cb88be4

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@chia7712
Copy link
Copy Markdown
Member Author

@vvcephei @mjsax Could you please take a look at this one-line change? This issue slowdown streams_eos_test(10 mins) and it obstructs us from running system tests on Travis (due to timeout).

@mjsax mjsax added streams tests Test fixes (including flaky tests) labels Dec 22, 2020
@mjsax mjsax changed the title KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break l… KAFKA-10815 EosTestDriver#verifyAllTransactionFinished should break loop if all partitions are verified Dec 22, 2020
Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Great find @chia7712! -- Can you make sure to cherry-pick this fix to older branches, too? At least 2.7, maybe even further. Leave it up to your judgment.

@chia7712 chia7712 merged commit 9aeacb4 into apache:trunk Dec 23, 2020
chia7712 added a commit to chia7712/kafka that referenced this pull request Dec 23, 2020
…oop if all partitions are verified (apache#9706)

Reviewers: Matthias J. Sax <mjsax@apache.org>
chia7712 added a commit to chia7712/kafka that referenced this pull request Dec 23, 2020
…oop if all partitions are verified (apache#9706)

Reviewers: Matthias J. Sax <mjsax@apache.org>
chia7712 added a commit that referenced this pull request Dec 23, 2020
…oop if all partitions are verified (#9706) (#9782)

Reviewers: Matthias J. Sax <mjsax@apache.org>
chia7712 added a commit that referenced this pull request Dec 23, 2020
…oop if all partitions are verified (#9706) (#9783)

Reviewers: Matthias J. Sax <mjsax@apache.org>
@mjsax
Copy link
Copy Markdown
Member

mjsax commented Dec 23, 2020

@chia7712 -- thanks for getting this into 2.7 and 2.6. (Btw: there is no need to do PRs. You can also cherry-pick and push directly.)

@chia7712
Copy link
Copy Markdown
Member Author

thanks for getting this into 2.7 and 2.6. (Btw: there is no need to do PRs. You can also cherry-pick and push directly.)

Thanks for kind reminder!

@chia7712 chia7712 deleted the KAFKA-10815 branch March 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants