Skip to content

KYLIN-4864 Fix .travis.yml syntax#1700

Merged
hit-lacus merged 2 commits intoapache:masterfrom
martin-g:master
Aug 2, 2021
Merged

KYLIN-4864 Fix .travis.yml syntax#1700
hit-lacus merged 2 commits intoapache:masterfrom
martin-g:master

Conversation

@martin-g
Copy link
Copy Markdown
Member

Proposed changes

The commented line about # mvn sonar:sonar -e -Dsonar.host.url=https://sonarcloud.io ... has broken the YAML and because of this TravisCI didn't execute any jobs.
I wasn't able to find a way to preserve the commented line and fix the syntax, so I removed the line. Later it could be get from Git history to re-enable Sonar.

While here I've improved few more things:

  • install OpenJDK and unzip for both AMD64 and ARM64. This way it uses latest JDK 8 (1.8.0_292) for both CPU architectures
  • fix more YAML warnings

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • [ x ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

This PR fixes the setup of TravisCI.
But it seems there are failing tests from before which are not related to this PR.

The commented line about `# mvn sonar:sonar -e -Dsonar.host.url=https://sonarcloud.io ...` has broken the YAML and because of this TravisCI didn't execute any jobs.
I wasn't able to find a way to preserve the commented line and fix the syntax, so I removed the line. Later it could be get from Git history to re-enable Sonar.

While here I've improved few more things:
- install OpenJDK and unzip for both AMD64 and ARM64. This way it uses latest JDK 8 (1.8.0_292) for both CPU architectures
- fix more YAML warnings
@martin-g
Copy link
Copy Markdown
Member Author

This PR is related to #1558.
// CC @liusheng

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 27, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.11%. Comparing base (0250081) to head (6233756).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1700      +/-   ##
============================================
- Coverage     25.42%   25.11%   -0.31%     
- Complexity     6765     6774       +9     
============================================
  Files          1508     1518      +10     
  Lines         93918    95184    +1266     
  Branches      13158    13294     +136     
============================================
+ Hits          23877    23909      +32     
- Misses        67662    68893    +1231     
- Partials       2379     2382       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

There is some problem with resolving the local address on the arm64 node (non-graviton2) - https://travis-ci.community/t/sudo-unable-to-resolve-host/8841
@hit-lacus
Copy link
Copy Markdown
Member

Thanks @martin-g !

@martin-g
Copy link
Copy Markdown
Member Author

@hit-lacus Welcome!

Where could I find the source code of the website ? I'd like to fix https://kylin.apache.org/development/#ci-and-code-analysis. Currently it points to Jenkins, i.e. error 404.

@martin-g
Copy link
Copy Markdown
Member Author

I think I've found it!
http://svn-master.apache.org/repos/asf/kylin/site/ - is this the one ?

@hit-lacus
Copy link
Copy Markdown
Member

hit-lacus commented Jul 28, 2021

I think I've found it!
http://svn-master.apache.org/repos/asf/kylin/site/ - is this the one ?

The source code of apache kylin is located at https://github.com/apache/kylin/document . https://github.com/apache/kylin/tree/document is the official website , not the svn .

@hit-lacus
Copy link
Copy Markdown
Member

@martin-g
Copy link
Copy Markdown
Member Author

Docu update - #1704

Copy link
Copy Markdown
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hit-lacus hit-lacus merged commit fef7803 into apache:master Aug 2, 2021
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Nov 4, 2021
* KYLIN-4864 Fix .travis.yml syntax

The commented line about `# mvn sonar:sonar -e -Dsonar.host.url=https://sonarcloud.io ...` has broken the YAML and because of this TravisCI didn't execute any jobs.
I wasn't able to find a way to preserve the commented line and fix the syntax, so I removed the line. Later it could be get from Git history to re-enable Sonar.

While here I've improved few more things:
- install OpenJDK and unzip for both AMD64 and ARM64. This way it uses latest JDK 8 (1.8.0_292) for both CPU architectures
- fix more YAML warnings

* KYLIN-4864 Use Graviton2 ARM64 node

There is some problem with resolving the local address on the arm64 node (non-graviton2) - https://travis-ci.community/t/sudo-unable-to-resolve-host/8841
hit-lacus pushed a commit that referenced this pull request Nov 5, 2021
* KYLIN-4864 Fix .travis.yml syntax

The commented line about `# mvn sonar:sonar -e -Dsonar.host.url=https://sonarcloud.io ...` has broken the YAML and because of this TravisCI didn't execute any jobs.
I wasn't able to find a way to preserve the commented line and fix the syntax, so I removed the line. Later it could be get from Git history to re-enable Sonar.

While here I've improved few more things:
- install OpenJDK and unzip for both AMD64 and ARM64. This way it uses latest JDK 8 (1.8.0_292) for both CPU architectures
- fix more YAML warnings

* KYLIN-4864 Use Graviton2 ARM64 node

There is some problem with resolving the local address on the arm64 node (non-graviton2) - https://travis-ci.community/t/sudo-unable-to-resolve-host/8841
zhangayqian pushed a commit to zhangayqian/kylin that referenced this pull request Nov 9, 2021
* KYLIN-4864 Fix .travis.yml syntax

The commented line about `# mvn sonar:sonar -e -Dsonar.host.url=https://sonarcloud.io ...` has broken the YAML and because of this TravisCI didn't execute any jobs.
I wasn't able to find a way to preserve the commented line and fix the syntax, so I removed the line. Later it could be get from Git history to re-enable Sonar.

While here I've improved few more things:
- install OpenJDK and unzip for both AMD64 and ARM64. This way it uses latest JDK 8 (1.8.0_292) for both CPU architectures
- fix more YAML warnings

* KYLIN-4864 Use Graviton2 ARM64 node

There is some problem with resolving the local address on the arm64 node (non-graviton2) - https://travis-ci.community/t/sudo-unable-to-resolve-host/8841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants