Skip to content

KYLIN-5053 Update the website to link to TravisCI and Github Actions instead of Jenkins#1704

Merged
hit-lacus merged 1 commit intoapache:documentfrom
martin-g:KYLIN-5053-update-links-to-CI
Nov 3, 2021
Merged

KYLIN-5053 Update the website to link to TravisCI and Github Actions instead of Jenkins#1704
hit-lacus merged 1 commit intoapache:documentfrom
martin-g:KYLIN-5053-update-links-to-CI

Conversation

@martin-g
Copy link
Copy Markdown
Member

Proposed changes

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ x ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ x ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • [ x ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

@martin-g martin-g mentioned this pull request Jul 28, 2021
8 tasks
@martin-g
Copy link
Copy Markdown
Member Author

I didn't update the Chinese version (index.cn.md) because I didn't want to use Google Translate.
Any help with this is welcome! // CC @liusheng

@liusheng
Copy link
Copy Markdown

@martin-g Thanks a lot for doing this, I have updated the Chinese index.cn.md here: liusheng#2, you can copy

@martin-g
Copy link
Copy Markdown
Member Author

Thank you, @liusheng !
I've added the change to this PR!

@Humbedooh
Copy link
Copy Markdown
Member

This won't get your web site deployed via git, as your configuration is the wrong way around.
The subdir refers to a sub directory on the web site to check out into, not a sub directory in the git branch. You are essentially checking your new website into kylin.apache.org/website/website with this. You need to remove the subdir directive and either:

  • publish the website content at the root of the branch OR
  • publish it in a directory called either output or content

@Humbedooh
Copy link
Copy Markdown
Member

For some reason https://infra-reports.apache.org/site-source/ still believes that Kylin's website comes from Subversion. @Humbedooh Do you have an idea why ?

Why would it believe anything else? Where else is your web site present in a published version?

@martin-g
Copy link
Copy Markdown
Member Author

I'll let @hit-lacus answer on that since I am not familiar how it works exactly.
I have the feeling that the Kylin devs use Github branch document for PRs and then copy manually the contents of _site folder to SVN.

@Humbedooh
Copy link
Copy Markdown
Member

Is this a Jekyll website? If so, you can just use the auto-build-and-publish features in .asf.yaml here.
See https://github.com/apache/thrift-website or https://github.com/apache/fluo-website for examples on how to utilize it.

Comment thread website/README.md Outdated
4. `git commit -m 'UPDATE MESSAGE'`

Within a few minutes, svnpubsub should kick in and you'll be able to
Within a few minutes, gitpubsub should kick in and you'll be able to
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martin-g , If you only use git to update the website content to the https://github.com/apache/kylin, you cannot directly update the kylin website. Because the code of kylin website is actually placed in SVN, and GitHub repo is just a transit station, it still needs to be updated to SVN in order to really update the http://kylin.apache.org/, so I don't think this part of the document content needs to be changed.

Comment thread website/README.md Outdated
Within a few minutes, gitpubsub should kick in and you'll be able to
see the results at
[http://kylin.apache.org](http://kylin.apache.org/). No newline at end of file
[https://kylin.apache.org](https://kylin.apache.org/). No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martin-g. The apache kylin official website protocol is indeed http rather than https.

Comment thread website/_dev/index.cn.md
### CI 和代码分析
使用 JDK 1.8 的 master 分支上的 UT:[Kylin-Master-JDK-1.8](https://builds.apache.org/job/Kylin-Master-JDK-1.8/)
静态代码分析:[SonarCube dashboard](https://builds.apache.org/analysis/overview?id=org.apache.kylin%3Akylin)
使用[GitHub Actions](https://github.com/apache/kylin/actions) 执行Linux x86平台上的单元测试,使用
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martin-g , I think both x86 and arm64 run on https://app.travis-ci.com/github/apache/kylin, but they run separately in two times.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the English version!

@martin-g
Copy link
Copy Markdown
Member Author

I'll revert the changes in README and .asf.yaml!

@martin-g
Copy link
Copy Markdown
Member Author

Done!

@martin-g
Copy link
Copy Markdown
Member Author

martin-g commented Aug 9, 2021

Any other feedback ?

@martin-g
Copy link
Copy Markdown
Member Author

martin-g commented Sep 1, 2021

Ping!

@martin-g
Copy link
Copy Markdown
Member Author

@zhangayqian Could you please take a look at this PR ? Thanks!

Copy link
Copy Markdown
Member

@hit-lacus hit-lacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hit-lacus hit-lacus merged commit 4364922 into apache:document Nov 3, 2021
@zhangayqian
Copy link
Copy Markdown
Contributor

zhangayqian commented Nov 3, 2021

@zhangayqian Could you please take a look at this PR ? Thanks!

Merged. Thank you for you contribution!

@martin-g martin-g deleted the KYLIN-5053-update-links-to-CI branch November 3, 2021 07:47
@martin-g
Copy link
Copy Markdown
Member Author

martin-g commented Nov 3, 2021

@zhangayqian Thanks for merging!
But it seems something happened with https://github.com/apache/kylin/pull/1558/files. In this PR arm64 has been added to .travis.yml but it is no more there (https://github.com/apache/kylin/blob/main/.travis.yml). And I don't see it in the Git history of this file. Maybe it got lost with the rename of master to main ?

Edit: fixed with #1757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants