[SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2

[wilx]

This pull request updates JUnit5 dependencies including its Vintage engine to current to fix the bug where it is unable to parse junit 4.13.2 version number.

https://issues.apache.org/jira/browse/SUREFIRE-2121

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[wilx]

OK. I was too quick. It fixes the test for me but it breaks other parts of surefire because of API changes in Jupiter Engine. I am not sure I know how to deal with those.

[andpab]

As described in my comment in SUREFIRE-2121, this pull request does not address the root cause of the issue which is simply a configuration error. There is no need to update the JUnit 5 version used internally by Surefire.

It might however be a good idea to update the JUnit 4 version and the junit-vintage-engine dependency in some of the tests as well as in the documentation to avoid similar misconceptions.

[andpab]

I've updated the versions in SUREFIRE-2138 (PR #590), so once the next release is made, the examples on the website will show up-to-date versions.

[slawekjaranowski]

I assume that it can be closed - right?

[andpab]

Definitely. The corresponding JIRA issue SUREFIRE-2121 can also be closed as Won't Fix.

If you're in the process of cleaning up, the PR #493 can be closed as well. And the respective issue SUREFIRE-2039 can be closed as a duplicate of SUREFIRE-2032.

The following issues have apparently been fixed according to the comments:

• SUREFIRE-2096 (fixed in 3.0.0-M8)
• SUREFIRE-2094 (fixed in 3.0.0-M8)
• SUREFIRE-2068 (fixed in 3.0.0-M7)

There are also a couple of other issues that in my opinion can be closed as Won't Fix:

• SUREFIRE-2120
• SUREFIRE-2115

[slawekjaranowski]

@wilx thanks for effort.
@andpab thanks for summary issues to close.

[jira-importer]

Resolve #2831