Skip to content

[SUREFIRE-2138] Update Junit4/5 version in docs and ITs#590

Merged
slawekjaranowski merged 2 commits intoapache:masterfrom
andpab:SUREFIRE-2138
Jan 3, 2023
Merged

[SUREFIRE-2138] Update Junit4/5 version in docs and ITs#590
slawekjaranowski merged 2 commits intoapache:masterfrom
andpab:SUREFIRE-2138

Conversation

@andpab
Copy link
Copy Markdown
Contributor

@andpab andpab commented Dec 29, 2022

  • Update JUnit versions referenced in configuration examples
    to 4.13.2 and 5.9.1, the respective latest versions
  • Add 4.13.1 and 4.13.2 to JUnitVersion and JUnit4VersionsIT
  • Use 4.13.2 where 4.13 or 4.13.1 was used in ITs
  • Use 5.9.1 in all ITs except if a specific version is needed
  • Add the necessary requires for org.junit.jupiter.api to the
      module-info.java where it was still missing

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@andpab
Copy link
Copy Markdown
Contributor Author

andpab commented Dec 29, 2022

The IT failure on macOS with jdk17 seems to be unrelated. It's Surefire1179IT which is a TestNG test that should be entirely unaffected by my changes. Probably a flaky test of sorts. I'll try to trigger a new build.

andpab added 2 commits January 2, 2023 18:55
Update JUnit versions referenced in configuration examples
to 4.13.2 and 5.9.1, the respective latest versions
- Add 4.13.1 and 4.13.2 to JUnitVersion and JUnit4VersionsIT
- Use 4.13.2 where 4.13 or 4.13.1 was used
- Use 5.9.1 in all tests except if a specific version is needed
- Add the necessary requires for org.junit.jupiter.api to the
  module-info.java where it was still missing
@slawekjaranowski slawekjaranowski merged commit d3dafe4 into apache:master Jan 3, 2023
@andpab andpab deleted the SUREFIRE-2138 branch January 3, 2023 19:16
@andpab
Copy link
Copy Markdown
Contributor Author

andpab commented Jan 4, 2023

@slawekjaranowski Thanks for reviewing and merging. Is there anything else that needs to be triggered so that the website is updated or is it only updated when a new release is made?

Currently it still shows the old state: https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit.html

@slawekjaranowski
Copy link
Copy Markdown
Member

@andpab site is updated during release with new version.

I'm looking into current changes, I think that new release will be appreciated.

So I will try to take care about it .... probably at the end of month. 😄

@andpab
Copy link
Copy Markdown
Contributor Author

andpab commented Jan 4, 2023

That's great news. Looking forward to it.

@jira-importer
Copy link
Copy Markdown

Resolve #2777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants