[SUREFIRE-2138] Update Junit4/5 version in docs and ITs#590
[SUREFIRE-2138] Update Junit4/5 version in docs and ITs#590slawekjaranowski merged 2 commits intoapache:masterfrom
Conversation
|
The IT failure on macOS with jdk17 seems to be unrelated. It's Surefire1179IT which is a TestNG test that should be entirely unaffected by my changes. Probably a flaky test of sorts. I'll try to trigger a new build. |
933f100 to
4f81f6e
Compare
Update JUnit versions referenced in configuration examples to 4.13.2 and 5.9.1, the respective latest versions
- Add 4.13.1 and 4.13.2 to JUnitVersion and JUnit4VersionsIT - Use 4.13.2 where 4.13 or 4.13.1 was used - Use 5.9.1 in all tests except if a specific version is needed - Add the necessary requires for org.junit.jupiter.api to the module-info.java where it was still missing
|
@slawekjaranowski Thanks for reviewing and merging. Is there anything else that needs to be triggered so that the website is updated or is it only updated when a new release is made? Currently it still shows the old state: https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit.html |
|
@andpab site is updated during release with new version. I'm looking into current changes, I think that new release will be appreciated. So I will try to take care about it .... probably at the end of month. 😄 |
|
That's great news. Looking forward to it. |
|
Resolve #2777 |
to 4.13.2 and 5.9.1, the respective latest versions
module-info.java where it was still missing
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.