[MWAR-444] Update plugin (requires Maven 3.2.5+) #20
Conversation
Move maven to proper scope, update dependencies, remove unused ones.
| <mavenArchiverVersion>3.5.1</mavenArchiverVersion> | ||
| <mavenFilteringVersion>3.1.1</mavenFilteringVersion> | ||
| <mavenVersion>3.1.0</mavenVersion> | ||
| <mavenVersion>3.2.5</mavenVersion> |
There was a problem hiding this comment.
Is this required? Personally I'm OK with it. However mostly I think we've been setting 3.1.1 as out minimum lately.
There was a problem hiding this comment.
This is requirement dictated by maven-plugin-testing-harness v 3.3.0
There was a problem hiding this comment.
we can stay with p-p-testing 3.1.0 as for the other 3.1.1. based plugins. Unfortunately, if the resources plugin will go for 3.2 then 3.2 will be our minimal version for everything (no other 3.x rel if we want to remove on 2.x plugins)
There was a problem hiding this comment.
Personally I'm OK with that. In fact, I'd be willing to go at least as far as 3.3 as a minimum. Is it worth asking on the dev list to see if we can get consensus on this as a cross-project minimum from now on?
There was a problem hiding this comment.
Yes, agree. i have same opinion here
There was a problem hiding this comment.
I even have another opinion. When Maven 3.9.0 will be released by end of this year I would base ALL baseline to 3.5.4 and burry anything below. There is no reason to support 8-year old Maven. Maven 3.5.4 will be 3,5 years old by then.
There was a problem hiding this comment.
I feel like there's a package manager I've encountered in the recent past (brew? Debian apt-get?) that installs 3.3.x by default. That's why I chose that version.
There was a problem hiding this comment.
I feel like there's a package manager I've encountered in the recent past (brew? Debian apt-get?) that installs 3.3.x by default. That's why I chose that version.
That is purely a Debian problem. Moreover, Debien screws up Maven to FUBAR.
There was a problem hiding this comment.
brew on Mac OS install the latest version of Maven
cstamas
changed the title
| <groupId>org.codehaus.plexus</groupId> | ||
| <artifactId>plexus-archiver</artifactId> | ||
| <version>4.2.2</version> | ||
| <version>4.2.5</version> |
There was a problem hiding this comment.
4.2.7 is out
But until the maven-war-plugin uses Java 8, that would require to downgrade commons-compress and plexus-utils, and my guess is that to simplify transitive dependency management, this just sets the latest that has bytecode 51.
There was a problem hiding this comment.
We are moving everything to 8
There was a problem hiding this comment.
Sure, yet this project is still Java 7:
Line 68 in 4355af5
So, ideally bump here to Java 8 and update plexus-archiver to 4.2.7, or bump it on another PR.
Merge pull request apache#20 from apache/update-plugin
|
Resolve #516 |
1 similar comment
|
Resolve #516 |
8 participants
Move maven to proper scope, update dependencies,
remove unused ones.
https://issues.apache.org/jira/browse/MWAR-444