Skip to content

[MWAR-453] Require Java 8 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slachiewicz merged 1 commit into from
Jun 2, 2022
Merged

[MWAR-453] Require Java 8 #23

slachiewicz merged 1 commit into from
Jun 2, 2022

Conversation

@slachiewicz
Copy link
Member

@slachiewicz slachiewicz commented Apr 22, 2022

No description provided.

@slachiewicz slachiewicz mentioned this pull request Apr 22, 2022
Merged
@dennisl
Copy link
Contributor

dennisl commented Apr 25, 2022

@slachiewicz Would you mind rebasing your branch to master, now that MWAR-444 and MWAR-450 has been merged. I don't trust myself to do that right now.

@dennisl
Copy link
Contributor

dennisl commented May 9, 2022

I have merged master into this branch to make sure that all the checks are green, which they are now. Do we need someone to review this PR?

@bmarwell
Copy link

bmarwell commented May 18, 2022

@dennisl can you drop the commit which merges master into this branch and do a rebase instead please?

bmarwell
bmarwell requested changes May 18, 2022
View reviewed changes
Copy link

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some open questions, but changes requested mainly due to merge commit.

src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java Outdated

// Ok now check that there is no more files/directories
final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } );
final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} );
Copy link

@bmarwell bmarwell May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not a Java 8 change.

Copy link
Member Author

@slachiewicz slachiewicz May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be reverted

src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java Outdated

// Ok now check that there is no more files/directories
final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } );
final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} );
Copy link

@bmarwell bmarwell May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not a Java 8 change.

Copy link
Member Author

@slachiewicz slachiewicz May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

src/test/java/org/apache/maven/plugins/war/WarOverlaysTest.java Outdated

// Ok now check that there is no more files/directories
final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] { MANIFEST_PATH } );
final FileFilter filter = new FileFilterImpl( webAppDirectory, new String[] {MANIFEST_PATH} );
Copy link

@bmarwell bmarwell May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not a Java 8 change.

Copy link
Member Author

@slachiewicz slachiewicz May 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@bmarwell
Copy link

bmarwell commented May 18, 2022

@olamy told me the merge commit will go away due to squashing anyway. Forget my previous comment about dropping and rebasing.

michael-o
michael-o requested changes May 18, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • those from Captain Marvel

michael-o
michael-o requested changes May 18, 2022
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MANIFEST_PATH issue is still there.

@slachiewicz
Copy link
Member Author

slachiewicz commented May 18, 2022

Sorry, all changes was done from scratch and looks like Intellij automatically makes this changes

@slachiewicz slachiewicz merged commit c784a39 into master Jun 2, 2022
@slachiewicz slachiewicz deleted the MWAR-453 branch June 2, 2022 11:25
@jira-importer
Copy link

jira-importer commented Jun 12, 2025

Resolve #525

1 similar comment
@jira-importer
Copy link

jira-importer commented Jun 12, 2025

Resolve #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o michael-o requested changes

@bmarwell bmarwell bmarwell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slachiewicz @dennisl @bmarwell @jira-importer @michael-o