[MNG-7131] maven.config doesn't handle arguments with spaces in them

[jira-importer]

Stefan Oehme opened MNG-7131 and commented

I tried putting a path with a space in the maven.config like so:

"-Dmy.path=/some/path with/a/space"

When asking for the my.path property inside Maven, I get the path with a trailing quote

/some/path with/a/space"

The file is parsed by splitting it by whitespace. I suggest replacing that code with the much better CommandLineUtils.translateCommandline(argLine)

---

Affects: 3.6.3

Issue Links:

• MNG-7684 With Maven 3.9.0, maven.config requires each flag on a separate line
  ("causes")

• MNG-8226 Unable to parse maven.config

• MNG-5857 Arguments from command line should override those in .mvn/maven.config

• MNG-7651 Simplify and document merge of maven.config file and CLI args

Remote Links:

• GitHub Pull Request #819
  
• GitHub Pull Request #488
  

Backported to: 4.0.0-alpha-2, 3.9.0

0 votes, 5 watchers

[jira-importer]

Michael Osipov commented

I think there is already a similar issue and I answered how to solve it...

[jira-importer]

Michael Osipov commented

I general idea was back then to move the config files jvm.config and maven.config to a line based approach like many other applications are using, Python's argparse, eclipse.ini, curl input file, Java @files, etc.

[jira-importer]

Michael Osipov commented

It seems that jvm.config is already processed that way.

[jira-importer]

Michael Osipov commented

Stefan Oehme, I'd be willing to provide a fix for this. Would you be willing to provide an IT with a PR? The most basic one is just like your usecase with a property. This could be written to a file and then verified to be present. We have many ITs of this kind. There is a specialized plugin in the Core IT Suite for this. WDYT?

[jira-importer]

Michael Osipov commented

Stefan Oehme, still interested in this?

[jira-importer]

Stefan Oehme commented

Sorry for not getting back to you on this. This is not an important issue for me, I just stumbled upon it while exploring Maven's behavior and thought I'd report it. I won't have time to work on this. The description has all the info that anyone who wants to work on this will need though.

[jira-importer]

Michael Osipov commented

Stefan Oehme, PR is there. Have a look.

[jira-importer]

Michael Osipov commented

Fixed with 0696cf14adec8fc4939b938844cfa93f421c1dfe.

[jira-importer]

Stefan Oehme commented

Lgtm

[jira-importer]

Michael Osipov commented

Please not that this PR might change with the introduction of MNG-7193.

[jira-importer]

Michael Osipov commented

Fixed with 331c5c3435cdfa8dc3f35a7b38503bdac2654206 for maven-3.9.x branch.

[jira-importer]

Jeff Pierson commented

I'm seeing a similar issue in Alpha 5 with an existing maven.config file that I had used back with Maven 3. The content of the file is as shown below.

-s .mvn/settings.xml

When I run mvn clean install with Maven 4 I get the following error:

[ERROR] Error executing Maven.
[ERROR] The specified user settings file does not exist: C:\projects\online-application-service\ .mvn\settings.xml

I noticed that there was a space before ".mvn" in the path so I removed it from maven.config in my .mvn folder and it worked.

maven.conf working in Maven 4 Alpha 5 (notice the space removed after -s.
-s.mvn/settings.xml

[jira-importer]

Michael Osipov commented

That is expected.

[jira-importer]

Jeff Pierson commented

Michael Osipov, ok so this is an expected breaking change? I couldn't find much details in documentation or other discussion other than the change to put arguments on separate lines. Is the workaround that I found the preferred one because like the original poster I did try quoting the argument value such as below which also didn't work.

-s ".mvn/settings.xml"

and

"-s .mvn/settings.xml"

At the same time I see that this issue which is about the allowing spaces with quoting behavior is marked fixed in previous versions. So I'm now wondering that if -s .mvn/settings.xml is not a regression from Maven 3 and an intentional breaking change on whether my attempt to quote the value as "-s .mvn/settings.xml" is a regression somewhere in the Maven 4 Alphas. Is there somewhere that explains this behavior and the breaking changes so that I can plan next steps for my projects which will adopt Maven 4 or help to open a new issue?

[jira-importer]

Michael Osipov commented

Please look at the commit message it contains a reasonable explanation for the fix. The approach was wrong from begin with. Many of our components reimplement shell functions which is wrong.

At the end the formula is simple: one argument == one line. No ambiguity.

Note that the previous behavior wad never formally specified.