Conversation
| if ( configFile.isFile() ) | ||
| { | ||
| for ( String arg : new String( Files.readAllBytes( configFile.toPath() ) ).split( "\\s+" ) ) | ||
| for ( String arg : Files.readAllLines( configFile.toPath(), Charset.defaultCharset() ) ) |
There was a problem hiding this comment.
Note: I have retained the original file encoding because jvm.config is subject to the same platform encoding. We can consider making maven.config UTF-8 only.
Since we don't have a clear specification of the file format change reading of the file to a one-arg-per-line basis just like Java's @argfiles or Python's argparse would handle it. Consider that jvm.config suffers from the same issue its parsing is not portable between Bourne shell and Windows Command prompt.
|
@rfscholte Should this be back ported to 3.8.x too? |
|
I don't know what your goal with the backport is or what the scope is. I'm just worried that it becomes bigger and bigger. |
Goal is actually consistency when migrating from 3 to 4. But you are right, this isn't a regression. Just an improvement of an edge case. If someone needs that in 3.x they can still raise a hand. |
|
Merged. |
|
Resolve #8332 |
Since we don't have a clear specification of the file format change
reading of the file to a one-arg-per-line basis just like Java's
@argfiles or Python's argparse would handle it.
Consider that jvm.config suffers from the same issue its parsing is not
portable between Bourne shell and Windows Command prompt.
We also need to change this and mention that
jvm.configparsing is not portable.I am inclined to backport this to 3.8.x although this might break for people for two reasons: