[3.x][MNG-7129] Necessary changes to support maven caching#622
Closed
gnodet wants to merge 1 commit intomaven-3.8.xfrom
Closed
[3.x][MNG-7129] Necessary changes to support maven caching#622gnodet wants to merge 1 commit intomaven-3.8.xfrom
gnodet wants to merge 1 commit intomaven-3.8.xfrom
Conversation
michael-o
reviewed
Nov 26, 2021
AlexanderAshitkin
left a comment
AlexanderAshitkin
left a comment
There was a problem hiding this comment.
cache realted part - looks good. lifecycle related change - cannot evaluate risks
michael-o
reviewed
Dec 1, 2021
maximilian-novikov-db
approved these changes
Dec 1, 2021
Contributor
Author
|
Anyone knows why the checks do not run ? @michael-o @rmannibucau |
Member
|
Only merge to master runs |
Contributor
Author
Should we enable running checks on supported branches ? |
Member
Would be good. I tripped over this multiple times |
gnodet
force-pushed
the
MNG-7129-3.8.x
branch
from
75f9a45 to
90373f0
Compare
gnodet
force-pushed
the
MNG-7129-3.8.x
branch
from
90373f0 to
ff554f1
Compare
AlexanderAshitkin
approved these changes
Dec 2, 2021
Member
|
I think this can be merged when 3.9.0 will be branched off. |
gnodet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MNG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.