[master][MNG-7129] Necessary changes to support maven caching#607
Closed
[master][MNG-7129] Necessary changes to support maven caching#607
Conversation
if attached artifacts already contains the artifact remove it and add the new one Signed-off-by: olivier lamy <olamy@apache.org>
The plugin key is build as combination of artifactId and groupId but not updated if either of these two ids change. This can be a problem if artifactId or groupId is a variable. The calculated key will likely contain the unresolved property and is not updated once the variable is interpolated. This closes #372
… dependencies This closes #311
This fixes following bug and also consistent with another 'cd /d "%EXEC_DIR%"' a few lines above. When you're on the root of some disk running mvn.cmd prints an extra line with current dir before the correct output Closes #304
Don't compare baseDir in a canonical form when the second comparing value (System.getProperty( "user.dir" )) is not canonicalized. This closes #361
…lified on Windows The removed 'stripMHome' recursive function is not needed anymore This closes #307
gnodet
force-pushed
the
MNG-7129-master
branch
from
6d1f26b to
b2e4577
Compare
…of artifacts The downloadTask.get() call is the one throwing exceptions, so those were ignored
This is an expected and recoverable error, so just log them at debug, especially as an info log statement is printed to indicate there has been an error.
…aster-db-subtree-feature # Conflicts: # maven-caching/src/main/java/org/apache/maven/caching/CacheControllerImpl.java # maven-caching/src/main/java/org/apache/maven/caching/xml/CacheConfigImpl.java
Contributor
Author
|
I've removed the extension from this branch so that it's now a standalone branch. This will allow adding integration tests on both |
gnodet
force-pushed
the
MNG-7129-master
branch
from
ac2cddc to
dc58d4b
Compare
Member
|
@gnodet As far as I understand this PR it solely changes Core to be able to plugin the caching module. Is that correct? |
Contributor
Author
gnodet
changed the title
gnodet
changed the title
maximilian-novikov-db
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of #606 on top of master.
This also supersedes #598.