Skip to content

[MNG-7324] switch from JAXB to Modello#598

Closed
hboutemy wants to merge 8 commits intoMNG-7129from
MNG-7129_Modello
Closed

[MNG-7324] switch from JAXB to Modello#598
hboutemy wants to merge 8 commits intoMNG-7129from
MNG-7129_Modello

Conversation

@hboutemy
Copy link
Copy Markdown
Member

No description provided.

Comment thread maven-core/src/main/mdo/cache-domain.mdo Outdated
@mthmulders mthmulders changed the title MMG-7129 switch from JAXB to Modello MNG-7129 switch from JAXB to Modello Oct 18, 2021
@gnodet
Copy link
Copy Markdown
Contributor

gnodet commented Nov 4, 2021

@hboutemy I've pushed additional commits to #604, getting rid of jaxb and fixing other bugs.

@hboutemy hboutemy changed the title MNG-7129 switch from JAXB to Modello [MNG-7324] switch from JAXB to Modello Nov 8, 2021
@hboutemy
Copy link
Copy Markdown
Member Author

hboutemy commented Nov 8, 2021

@AlexanderAshitkin @gnodet ok to merge this to MNG-7129 branch?

@gnodet
Copy link
Copy Markdown
Contributor

gnodet commented Nov 8, 2021

@AlexanderAshitkin @gnodet ok to merge this to MNG-7129 branch?

+1 for me, fwiw the doc will have to be updated at some point

@hboutemy
Copy link
Copy Markdown
Member Author

hboutemy commented Nov 8, 2021

@gnodet doc updated and models split to different Java packages corresponding to XML filenames

@gnodet
Copy link
Copy Markdown
Contributor

gnodet commented Nov 9, 2021

@gnodet doc updated and models split to different Java packages corresponding to XML filenames

I'd like to change the package names from buildinfo to build and buildsdiff to diff. Thoughts ?

Also, I'm not really sure it makes sense to work on several branches to actually create a branch that will be eventually merged to master. Should we simply commit to the original MNG-7129 branch ?
Maybe we can just rebase/merge the #606 branch which contains all the commits from this PR ?

@gnodet
Copy link
Copy Markdown
Contributor

gnodet commented Nov 10, 2021

Superseded by #607

@gnodet gnodet closed this Nov 10, 2021
@hboutemy
Copy link
Copy Markdown
Member Author

hboutemy commented Nov 11, 2021

@gnodet

I'd like to change the package names from buildinfo to build and buildsdiff to diff. Thoughts ?

No problem for me: I'm like you, I'm discovering, reading and trying to improve namings to better match what I think I understood
this is where I'd love to have feedback from initial developers

Also, I'm not really sure it makes sense to work on several branches...

we are defining/discovering how to work together: I like you idea on Jira sub-tasks, for example
On branches, I expected that we would manage to have feedback earlier, then merge to initial branch faster: I completely agree with you that it does not make sense to add many branches if we don't merge somewhere
let's continue on #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants