Skip to content

[MNG-7129] Incremental build and shared cache feature#597

Closed
hboutemy wants to merge 5 commits intomaven-3.8.xfrom
MNG-7129
Closed

[MNG-7129] Incremental build and shared cache feature#597
hboutemy wants to merge 5 commits intomaven-3.8.xfrom
MNG-7129

Conversation

@hboutemy
Copy link
Copy Markdown
Member

@hboutemy hboutemy commented Oct 17, 2021

after initial merge of Deutsche Bank donation to MNG-7129 branch #526, let's rework the code to better match Maven codebase

For example switching from jaxb2 to Modello

maximilian-novikov-db and others added 3 commits September 8, 2021 13:23
@maximilian-novikov-db @hboutemy
Merge pull request #4 in ABFX/maven-forked from incremental-maven-3.6…
a66d468 
….3 to MNG-7129/maven-3.6.3-incremental

Squashed commit of the following:

commit 21c620a34ddbbf84b3c44014b069a7b222cf91a7
Author: Maximilian Novikov <maximilian.novikov@db.com>
Date:   Tue Aug 10 19:41:41 2021 +0200

    Merge pull request #3 in ABFX/maven-forked from code-cleanup-2 to incremental-maven-3.6.3

    Squashed commit of the following:

    commit 3401739ec9eb957fb03887f6a3c24477c9c3327b
    Author: Alexander Ashitkin <alexander.ashitkin@db.com>
    Date:   Tue Aug 10 13:37:13 2021 -0400

        cleanup db specifics

    commit 5d32f00559951445ecaf7d5ec4d847541c10e7e9
    Author: Alexander Ashitkin <alexander.ashitkin@db.com>
    Date:   Tue Aug 10 11:05:28 2021 -0400

        cleanup db specifics

commit fcec28f82c0d447de64032c610b39fa75bb344b0
Merge: 6fd401af2 5b0dc1858
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date:   Mon Aug 9 13:22:16 2021 +0100

    Pull request #9: Remote cache setup

    Merge in BND/maven-forked from feature/remote-cache-setup to incremental-maven-3.6.3

    * commit '5b0dc1858cf4ca499502f0741b2f3bf2ac55530c':
      remote cache setup - fail fast, baseline build, diff reporting, documentation.

commit 5b0dc1858cf4ca499502f0741b2f3bf2ac55530c
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date:   Mon Mar 22 03:30:03 2021 +0100

    remote cache setup - fail fast, baseline build, diff reporting, documentation.

commit 6fd401af285692df568312ee66ee00edfe21f1cc
Author: Maximilian Novikov <maximilian.novikov@db.com>
Date:   Tue Apr 13 17:36:49 2021 +0100

    Pull request #8: Incremental Maven - added non-overrideable cache entries

    Merge in BND/maven-forked from non-overritable-build-info to incremental-maven-3.6.3

    Squashed commit of the following:

    commit 405bbef8a59cabc0b83e9a64717f65fbd6fb9e3d
    Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
    Date:   Mon Apr 12 20:18:27 2021 +0200

        Incremental Maven - added non-overrideable cache entries - review fixes

    commit 197704672756e558fb3521e16859d0be324044b8
    Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
    Date:   Fri Apr 9 11:35:48 2021 +0200

        Incremental Maven - added non-overrideable cache entries

commit 64c4b1f5cbdf920ad43560f34cc5be56d4557acf
Author: Alexander Ashitkin <alexander.ashitkin@db.com>
Date:   Tue Mar 9 04:10:20 2021 +0100

    injected version

commit 727e507ae2fd90dce7011f3f1c76eb4969577d5e
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date:   Wed Jan 13 16:17:25 2021 +0100

    Incremental Maven - Java 11 fix

commit b2f297566d5afcb0a285985cb5540685a28cafec
Author: maximilian.novikov@db.com <maximilian.novikov@db.com>
Date:   Tue Jan 12 14:10:08 2021 +0100

    Incremental Maven - initial commit
@hboutemy
fix typo
6e1f1ec
@hboutemy
add missing license
0c56674
@michael-o
Copy link
Copy Markdown
Member

michael-o commented Oct 17, 2021

Why into 3.8.x? Shouldn't this be Maven 4 for now?

@hboutemy
Copy link
Copy Markdown
Member Author

hboutemy commented Oct 17, 2021

step by step

@michael-o
Copy link
Copy Markdown
Member

michael-o commented Oct 17, 2021

I thought that incremental changes would happen in the branch only. So a branch from branch. This diff looks huge to me.

@hboutemy
Copy link
Copy Markdown
Member Author

hboutemy commented Oct 17, 2021

without PR, no review: I had to create a PR to create life :)

@hboutemy
Copy link
Copy Markdown
Member Author

hboutemy commented Oct 19, 2021 •
edited
Loading

This diff looks huge to me

yes
surely there is some rework to make this diff easier to evaluate and choose to merge into a main branch for a "normal" Maven release
I tried to move the whole "caching" package into a separate module a try to have a more visible separation of concerns, but 3 classes had dependencies on maven-core: MojoExecutionManager, ProjectUtils, CacheController. Then it's not so easy...

I chose to start by working on Modello migration #598, that will ease some parts: help welcome
any other idea on finding a concrete step to go forward are welcome

@maximilian-novikov-db
Copy link
Copy Markdown

maximilian-novikov-db commented Nov 8, 2021 •
edited
Loading

This diff looks huge to me

yes surely there is some rework to make this diff easier to evaluate and choose to merge into a main branch for a "normal" Maven release I tried to move the whole "caching" package into a separate module a try to have a more visible separation of concerns, but 3 classes had dependencies on maven-core: MojoExecutionManager, ProjectUtils, CacheController. Then it's not so easy...

I chose to start by working on Modello migration #598, that will ease some parts: help welcome any other idea on finding a concrete step to go forward are welcome

@hboutemy @michael-o we've prepared a change to the core, which will allow to move the caching module to an extension, it's in testing now. We're going to raise a pr in a week.

@gnodet
Copy link
Copy Markdown
Contributor

gnodet commented Nov 16, 2021

Superseded by #607

@gnodet gnodet closed this Nov 16, 2021
@slawekjaranowski slawekjaranowski deleted the MNG-7129 branch June 7, 2025 12:52
@slawekjaranowski
Copy link
Copy Markdown
Member

slawekjaranowski commented Jun 7, 2025

source branch deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hboutemy @michael-o @maximilian-novikov-db @gnodet @slawekjaranowski