Skip to content

[MNG-7447] Fix ReactorReader unintended change#709

Merged
cstamas merged 1 commit intomaven-3.9.xfrom
maven-3.9.x-reactorreader
Apr 8, 2022
Merged

[MNG-7447] Fix ReactorReader unintended change#709
cstamas merged 1 commit intomaven-3.9.xfrom
maven-3.9.x-reactorreader

Conversation

@cstamas
Copy link
Copy Markdown
Member

@cstamas cstamas commented Apr 8, 2022

The commit c604db3
changed ReactorReader to use MavenSession#getAllProjects()
instead of deprecated MavenSession#getProjectMap() that
is equivalent of MavenSession#getProjects().

This undoes this unintended change.

The commit c604db3
changed ReactorReader to use MavenSession#getAllProjects()
instead of deprecated MavenSession#getProjectMap() that
is equivalent of MavenSession#getProjects().

This undoes this unintended change.
@cstamas cstamas requested review from khmarbaise and michael-o April 8, 2022 12:08
@cstamas cstamas self-assigned this Apr 8, 2022
@cstamas
Copy link
Copy Markdown
Member Author

cstamas commented Apr 8, 2022

The problem is shown by maven-3.9.x branch, where these two IT fails

Error:  Errors: 
Error:    MavenITmng6090CIFriendlyTest>AbstractMavenIntegrationTestCase.runTest:265->testitShouldResolveTheDependenciesWithBuildConsumer:105 » Verification
Error:    MavenITmng6090CIFriendlyTest>AbstractMavenIntegrationTestCase.runTest:265->testitShouldResolveTheDependenciesWithoutBuildConsumer:76 » Verification

See CI runs of commit (that fixes other unrelated issue, that hid this original issue) 263cf95

@cstamas cstamas requested a review from slawekjaranowski April 8, 2022 12:18
@cstamas cstamas changed the title Fix ReactorReader unintended change [MNG-7447] Fix ReactorReader unintended change Apr 8, 2022
@cstamas cstamas merged commit 08dff22 into maven-3.9.x Apr 8, 2022
@cstamas cstamas deleted the maven-3.9.x-reactorreader branch April 8, 2022 16:24
gnodet pushed a commit to gnodet/maven that referenced this pull request Apr 12, 2022
The commit c604db3
changed ReactorReader to use MavenSession#getAllProjects()
instead of deprecated MavenSession#getProjectMap() that
is equivalent of MavenSession#getProjects().

This undoes this unintended change.
@gnodet gnodet mentioned this pull request May 24, 2023
@jira-importer
Copy link
Copy Markdown

Resolve #9142

@olamy olamy mentioned this pull request Apr 2, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants