[MNG-7454] Include resolver-transport-http in Maven 3.9.x#710
Merged
cstamas merged 4 commits intomaven-3.9.xfrom Apr 13, 2022
Merged
[MNG-7454] Include resolver-transport-http in Maven 3.9.x#710cstamas merged 4 commits intomaven-3.9.xfrom
cstamas merged 4 commits intomaven-3.9.xfrom
Conversation
But keep Wagon as default transport. This PR merely includes resolver http and file transport and switches wagon-http to non-shaded one. Changes: * switch to non-shaded wagon-http (as httpClient is now shared) * include resolver http and file transport * override resolver default behaviour (native transport preferred over wagon, when both on classpath) * provide simplistic means to choose transport The chosen transport can be seen in debug (-X) output on line `[DEBUG] Using transporter XXX...` The `-Dmaven.traport` simplistic switch can be used to choose tranport: * not set: default, that is Wagon * `wagon`: explicitly sets Wagon * `resolver`: explicitly sets resolver native transports (file and http) * `auto`: relies on resolver "auto discovery" (priorities, etc). This is MUST to keep transport pluggable with 3rd party transports. Note: resolver by default, if both wagon and native transports are present on classpath, would prefer native ones. Hence, to retain "wagon as default" this extra config bit is a must in Maven.
Member
Author
|
As branch maven-3.9.x is broken until #709 merged, MNG6090 ITs are expected to fail, but Wagon ancient (plexus XML and other) ITs should succeed. |
…ver-http-transport
Member
Author
|
Branch maven-3.9.x is fixed in the mean time, so now all ITs needs to pass. |
cstamas
changed the title
gnodet
approved these changes
Apr 11, 2022
Closed
|
Resolve #9137 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But keep Wagon as default transport. This PR merely includes
resolver http and file transport and switches wagon-http
to non-shaded one.
Changes:
The chosen transport can be seen in debug (-X) output on line
[DEBUG] Using transporter XXX...The
-Dmaven.transportsimplistic switch can be used to choose transport:wagon: explicitly sets Wagonresolver: explicitly sets resolver native transports (file and http)auto: relies on resolver "auto discovery" (priorities, etc). This is MUST to keep transport pluggable with 3rd party transports. In fact, this was the default so far in Maven, along with the fact that native resolver transports were not included (as resolver prefers native ones over Wagon).Note: resolver by default, if both wagon and native transports are present on classpath,
would prefer native ones. Hence, to retain "wagon as default" this extra config
bit is a must in Maven.