Trasnport: use config properties instead user properties.#735
Trasnport: use config properties instead user properties.#735
Conversation
| session.setAuthenticationSelector( authSelector ); | ||
|
|
||
| String transport = request.getUserProperties() | ||
| .getProperty( MAVEN_RESOLVER_TRANSPORT_KEY, MAVEN_RESOLVER_TRANSPORT_WAGON ); |
There was a problem hiding this comment.
So this is a merged, final version of the properties and the actual source is irrelevant?
There was a problem hiding this comment.
yup, this is "config" properties (merged plus added things). I think I understand from where "request.systemProperties" are sourced, but from where are "request.userProperties" sourced?
There was a problem hiding this comment.
Look into Maven CLI, that is the source for it. Commons CLI provides it and it is passed down the line.
There was a problem hiding this comment.
request.*Properties are populated in
https://github.com/apache/maven/blob/master/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
There was a problem hiding this comment.
IMHO this is correct change: we do want to allow setting transport in various ways, allowing the change to be "persistent". What we have on master works ONLY if you use -Dmaven.resolver.transport=xx on CLI and nothing else. This also allows CLI override (ie. you have it set in MAVEN_OPTS but you use -Dxxx on command line)
michael-o
left a comment
michael-o
left a comment
There was a problem hiding this comment.
Please create a JIRA issue, this needs to go into 3.9.0 and master.
|
Do we want to address build consumer feature as well? As it suffers from very same issue |
|
No, at least not for now. It is a user feature therefore a user property |
|
Superseded by #739 |
3 participants
This setting should be possible to be set via MAVEN_OPTS (system wide) or in .mvn/maven.config etc, Currently it is possible only via
-DxxxAFTER mvn....