[MNG-7478] Transport selection should use config properties#739
Merged
[MNG-7478] Transport selection should use config properties#739
Conversation
This was referenced May 13, 2022
slawekjaranowski
approved these changes
May 13, 2022
Member
|
Please look at jankis build ... |
Instead of user properties, as this allows making "permanent" the selection by using MAVEN_OPTS and other places as well. Currently only via command line works.
cstamas
force-pushed
the
mng-7475-transport-selection
branch
from
1ed0303 to
a085ed0
Compare
Contributor
|
@cstamas does that mean you wouldn't be able to use |
Member
Author
Nope, you can still use -D at command line, but also you can use MAVEN_OPTS (not currently) etc |
gnodet
approved these changes
May 17, 2022
cstamas
added a commit
that referenced
this pull request
May 17, 2022
Instead of user properties, as this allows making "permanent" the selection by using MAVEN_OPTS and other places as well. Currently only via command line works. Also, do not modify existing Maven behavior, so introduce "default" branch in selection. See comment in code
Closed
|
Resolve #8980 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of user properties, as this allows making "permanent" the
selection by using MAVEN_OPTS and other places as well. Currently
only via command line works.
Also, do not modify existing Maven behavior, so introduce "default" branch
in selection. See comment in code.
https://issues.apache.org/jira/browse/MNG-7478