Skip to content

MNG-7529 - 3.9.x port#785

Merged
hgschmie merged 0 commit intoapache:maven-3.9.xfrom
hgschmie:MNG-7529-3.9.x
Aug 21, 2022
Merged

MNG-7529 - 3.9.x port#785
hgschmie merged 0 commit intoapache:maven-3.9.xfrom
hgschmie:MNG-7529-3.9.x

Conversation

@hgschmie
Copy link
Copy Markdown
Contributor

Ensure that any versions resolved as part of a version range request
only reference repositories that are actually enabled for the type of
version (SNAPSHOT versions against snapshot repos, release versions
against release repositories).

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
    and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
    title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the [Core IT][core-its] successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@hgschmie hgschmie merged commit 29c53d6 into apache:maven-3.9.x Aug 21, 2022
@michael-o
Copy link
Copy Markdown
Member

Why? No one had reviewed this.

@slawekjaranowski
Copy link
Copy Markdown
Member

Maybe by mistake ...

  • pointing issue are not conected with change
  • zero commits in PR, PR was update after merge

@hgschmie - can you explain?

@michael-o
Copy link
Copy Markdown
Member

I am inclined to force push a revert. (Drop commit)

@hgschmie
Copy link
Copy Markdown
Contributor Author

I pushed locally the maven-3.9.x branch onto this by mistake. This turned it into "0 commits" and auto-closed it as merged. Nothing was actually pushed.

@hgschmie
Copy link
Copy Markdown
Contributor Author

I reopened that as #787, BTW. I was not aware that committers require review; Apache has traditionally always been CTR.

@michael-o
Copy link
Copy Markdown
Member

I reopened that as #787, BTW. I was not aware that committers require review; Apache has traditionally always been CTR.

We don't do CTR anymore because 3.4.0 caused a lot of havoc. Therefore, anything which isn't a simple typo/doc change goes through a PR. It takes more time, but achieves better quality.

@jira-importer
Copy link
Copy Markdown

Resolve #8932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants