[MNG-7529] Maven resolver makes bad repository choices when resolving version ranges

[jira-importer]

Henning Schmiedehausen opened MNG-7529 and commented

This is the same problem as MRESOLVER-270. The problem is actually in the maven core, not in the resolver. See the description there.

 

This bug is a placeholder for the fix PR.

---

Affects: 3.8.6

Issue Links:

• MRESOLVER-270 Maven resolver makes bad repository choices when resolving version ranges
  ("is duplicated by")

Remote Links:

• GitHub Pull Request #189
  
• GitHub Pull Request #784
  
• GitHub Pull Request #785
  
• GitHub Pull Request #786
  
• GitHub Pull Request #787
  
• GitHub Pull Request #789
  
• GitHub Pull Request #795
  
• GitHub Pull Request #796
  
• GitHub Pull Request #797
  

Backported to: 4.0.0-alpha-2, 3.9.0, 3.8.7

0 votes, 7 watchers

[jira-importer]

Henning Schmiedehausen commented

Now it has the fix issue for the next release candidates. 

[jira-importer]

Henning Schmiedehausen commented

Fixed on 3.8.x and 3.9.x branches and on master.

[jira-importer]

Konrad Windszus commented

This fix is IMHO incorrectly filtering the results afterwards while it needs to prevent asking SNAPSHOT remote repositories for metadata.xml in the first place when resolving non-SNAPSHOT versions. Why can't we just set the correct nature in

maven/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java

Line 151 in ce45791

MAVEN_METADATA_XML, Metadata.Nature.RELEASE_OR_SNAPSHOT );

and filter out non-relevant remote repos in

maven/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java

Lines 157 to 163 in ce45791

	for ( RemoteRepository repository : request.getRepositories() )
	{
	MetadataRequest metadataRequest = new MetadataRequest( metadata, repository, request.getRequestContext() );
	metadataRequest.setDeleteLocalCopyIfMissing( true );
	metadataRequest.setTrace( trace );
	metadataRequests.add( metadataRequest );
	}

in the first place?

[jira-importer]

Konrad Windszus commented

In fact the filtering of remote repos is already done in https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java#L413, so my previous statement is incorrect. Not sure about version ranges containing both releases and SNAPSHOTs (MNG-3092) so I am actually not sure if Metadata.Nature needs to be changed in

maven/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java

Line 151 in ce45791

MAVEN_METADATA_XML, Metadata.Nature.RELEASE_OR_SNAPSHOT );

.

[jira-importer]

Henning Schmiedehausen commented

you want to look at the integration test to understand the problem.

There has been plenty explanations written why this change solves a real problem. You can reread the comment thread here: #795