[MNG-7529] Maven resolver makes bad repository choices#789
Closed
hgschmie wants to merge 1 commit intoapache:masterfrom
Closed
[MNG-7529] Maven resolver makes bad repository choices#789hgschmie wants to merge 1 commit intoapache:masterfrom
hgschmie wants to merge 1 commit intoapache:masterfrom
Conversation
Ensure that any versions resolved as part of a version range request only reference repositories that are actually enabled for the type of version (SNAPSHOT versions against snapshot repos, release versions against release repositories).
Contributor
Author
|
got the integration tests to work. |
cstamas
reviewed
Aug 26, 2022
| return true; | ||
| } | ||
|
|
||
| boolean snapshot = version != null && version.endsWith( SNAPSHOT ); |
Member
There was a problem hiding this comment.
What about timestamped snapshots?
Contributor
Author
There was a problem hiding this comment.
Hi @cstamas ,
Thank you for looking at this. I do not understand this comment. The check is similar to the code in the DefaultVersionResolver (where it determines whether a local file is a SNAPSHOT version by checking that it ends with 'SNAPSHOT' (https://github.com/apache/maven/blob/master/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java#L208).
Can you explain a bit more what you mean by "timestamped snapshots" ?
|
Resolve #8932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing integration tests