Skip to content

[MNG-7529] Maven resolver makes bad repository choices #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hgschmie wants to merge 1 commit into from
Closed

[MNG-7529] Maven resolver makes bad repository choices #789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ...vider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ public class DefaultVersionRangeResolver

private static final String MAVEN_METADATA_XML = "maven-metadata.xml";

private static final String SNAPSHOT = "SNAPSHOT";

private final MetadataResolver metadataResolver;
private final SyncContextFactory syncContextFactory;
private final RepositoryEventDispatcher repositoryEventDispatcher;
Expand Down Expand Up @@ -183,9 +185,11 @@ private Map<String, ArtifactRepository> getVersions( RepositorySystemSession ses
}

Versioning versioning = readVersions( session, trace, metadataResult.getMetadata(), repository, result );
RemoteRepository remoteRepository = metadataResult.getRequest().getRepository();

for ( String version : versioning.getVersions() )
{
if ( !versionIndex.containsKey( version ) )
if ( isEnabled( remoteRepository, version ) && !versionIndex.containsKey( version ) )
{
versionIndex.put( version, repository );
}
Expand All @@ -195,6 +199,18 @@ private Map<String, ArtifactRepository> getVersions( RepositorySystemSession ses
return versionIndex;
}

private boolean isEnabled( RemoteRepository remoteRepository, String version )
{
if ( remoteRepository == null )
{
return true;
}

boolean snapshot = version != null && version.endsWith( SNAPSHOT );
Copy link
Copy Markdown
Member

@cstamas cstamas Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about timestamped snapshots?

Copy link
Copy Markdown
Contributor Author

@hgschmie hgschmie Aug 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cstamas ,

Thank you for looking at this. I do not understand this comment. The check is similar to the code in the DefaultVersionResolver (where it determines whether a local file is a SNAPSHOT version by checking that it ends with 'SNAPSHOT' (https://github.com/apache/maven/blob/master/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionResolver.java#L208).

Can you explain a bit more what you mean by "timestamped snapshots" ?


return remoteRepository.getPolicy( snapshot ).isEnabled();
}

private Versioning readVersions( RepositorySystemSession session, RequestTrace trace, Metadata metadata,
ArtifactRepository repository, VersionRangeResult result )
{
Expand Down Expand Up @@ -238,4 +254,4 @@ private void invalidMetadata( RepositorySystemSession session, RequestTrace trac
repositoryEventDispatcher.dispatch( event.build() );
}

}
}