Skip to content

Make sure RAT plugin ignores files in the target folder#813

Merged
gnodet merged 4 commits intoapache:masterfrom
gnodet:rat-target-master
Oct 5, 2022
Merged

Make sure RAT plugin ignores files in the target folder#813
gnodet merged 4 commits intoapache:masterfrom
gnodet:rat-target-master

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Oct 5, 2022

When switching branches, left-over target folder often causes issues with the rat-maven-plugin.
Ignoring those folders does help from a day-to-day pov.

See #814 and #815

@gnodet gnodet force-pushed the rat-target-master branch from ed89752 to 79312b1 Compare October 5, 2022 09:53
@gnodet gnodet requested a review from cstamas October 5, 2022 10:00
…in children, use a single place to configure rat
@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented Oct 5, 2022

@michael-o @cstamas I gave it another try
The rat plugin does read the .gitignore file to add excludes, but the syntax is slightly different in that it does not assume ** before and after the pattern, so I fixed the target/ into **/target/** so that it works for both.
If you add a repo/ and use that directory as the local repo, it should be ignore too.
I've also disabled the execution in child modules.

@gnodet gnodet merged commit 37b579b into apache:master Oct 5, 2022
gnodet added a commit to gnodet/maven that referenced this pull request Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
gnodet added a commit to gnodet/maven that referenced this pull request Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
gnodet added a commit that referenced this pull request Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
gnodet added a commit that referenced this pull request Oct 5, 2022
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
@gnodet gnodet deleted the rat-target-master branch October 5, 2022 14:57
@gnodet gnodet mentioned this pull request May 24, 2023
@olamy olamy mentioned this pull request Apr 2, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants