Skip to content

Make sure RAT plugin ignores files in the target folder#815

Merged
gnodet merged 1 commit intoapache:maven-3.9.xfrom
gnodet:rat-target-3.9.x
Oct 5, 2022
Merged

Make sure RAT plugin ignores files in the target folder#815
gnodet merged 1 commit intoapache:maven-3.9.xfrom
gnodet:rat-target-3.9.x

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Oct 5, 2022

No description provided.

@cstamas
Copy link
Copy Markdown
Member

cstamas commented Oct 5, 2022

better but not enough... if you do -Dmaven.repo.local=local RAT will belly up AGAIN.... best would be to make it smarter, but.. sigh.

@michael-o
Copy link
Copy Markdown
Member

michael-o commented Oct 5, 2022

better but not enough... if you do -Dmaven.repo.local=local RAT will belly up AGAIN.... best would be to make it smarter, but.. sigh.

Well, you can't make this right. I basically do ...=$PWD/../repo or ...=$(mktemp -d)

Comment thread pom.xml Outdated
<exclude>src/main/appended-resources/licenses/EPL-1.0.txt</exclude>
<exclude>src/main/appended-resources/licenses/unrecognized-aopalliance-1.0.txt</exclude>
<exclude>src/main/appended-resources/licenses/unrecognized-javax.annotation-api-1.3.2.txt</exclude>
<!-- exclude all files in the target folder -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directory, not folder

@cstamas
Copy link
Copy Markdown
Member

cstamas commented Oct 5, 2022

Well, you can't make this right. I basically do ...=$PWD/../repo or ...=$(mktemp -d)

So RAT scanns ALL files from project basedir? How it avoid scanning files multiple times, like when project modules are nested? Are they being over and over re-scanned as build progresses (and RAT plugin is inherited from top level module)?

@michael-o
Copy link
Copy Markdown
Member

Well, you can't make this right. I basically do ...=$PWD/../repo or ...=$(mktemp -d)

So RAT scanns ALL files from project basedir? How it avoid scanning files multiple times, like when project modules are nested? Are they being over and over re-scanned as build progresses (and RAT plugin is inherited from top level module)?

For this we need to check the source code of this plugin.

* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
@gnodet gnodet merged commit a7a5b81 into apache:maven-3.9.x Oct 5, 2022
@gnodet gnodet deleted the rat-target-3.9.x branch October 5, 2022 14:58
@gnodet gnodet mentioned this pull request May 24, 2023
@olamy olamy mentioned this pull request Apr 2, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants