-
Notifications
You must be signed in to change notification settings - Fork 505
METRON-1709 : Added the required scripts to start / stop PCAP topology from Ambari #1201
Conversation
…e required scripts to start/stop PCAP topology from Ambari.
|
I am not able to spin-up the Full Dev environment with this. It keeps failing here. Have you run this up in Full Dev? |
|
@nickwallen It's my bad I dint run this up in Full Dev, I verified my scripts on a 12 node cluster. I did the required changes to support the Full dev deploymwnt and updated the pull request. |
|
Can you merge this with master? It is hard to tell what is part of this PR. |
|
The configuration elements for PCAP are still under Metron > Configs > REST. Now that you've added stop/start, I think it would make sense to pull those out into its own component/panel, like the other topologies. I was able to spin it up, start the pcap topology, throw some pcap at it, and see it get archived in HDFS, then search for that pcap in the UI. So ya for that! |
…i. (MohanDV via nickwallen) closes apache#1201
… component (tiborm via nickwallen) closes apache#1180
|
@nickwallen having separate panel for PCAP configs is been addressed in the pull request 1132. It will be a duplicate effort here. |
Gotcha. I was not aware of the other PR. That will work. |
|
+1 Looks great. Thanks a bunch for the contribution. |
|
I want to hold off on the merge until we get the pcap properties change sorted on this. @anandsubbu is opening a re-opening a PR on that. |
|
Hi @nickwallen , I would like to create a fresh pull request based on these changes. Could you go ahead and merge this please ? |

Contributor Comments
Created PCAP topology as Metron component, Created required scripts to create kafka topic, hdfs folder for pcap sequence files with required ACL's and added controls to start / stop the PCAP topology from Ambari.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:
For code changes:
Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
For documentation related changes:
Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via
site-book/target/site/index.html:Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.