Skip to content
This repository was archived by the owner on Aug 20, 2025. It is now read-only.

Conversation

@MohanDV
Copy link
Contributor

@MohanDV MohanDV commented Sep 18, 2018

Contributor Comments

Created PCAP topology as Metron component, Created required scripts to create kafka topic, hdfs folder for pcap sequence files with required ACL's and added controls to start / stop the PCAP topology from Ambari.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

  • Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
  • Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

  • Have you included steps to reproduce the behavior or problem that is being changed or addressed?

  • Have you included steps or a guide to how the change may be verified and tested manually?

  • Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

    mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
    
  • Have you written or updated unit tests and or integration tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

  • Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

    cd site-book
    mvn site
    

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

…e required scripts to start/stop PCAP topology from Ambari.
@nickwallen
Copy link
Contributor

I am not able to spin-up the Full Dev environment with this. It keeps failing here. Have you run this up in Full Dev?

TASK [ambari_config : Deploy cluster with Ambari; http://node1:8080] ***********
fatal: [node1]: FAILED! => {"changed": false, "failed": true, "msg": "Ambari client exception occurred: Could not create blueprint: request code 400,                     request message {\n  \"status\" : 400,\n  \"message\" : \"Cluster Topology validation failed.  Invalid service component count: [METRON_PCAP(actual=0, required=1)].  To disable topology validation and create the blueprint, add the following to the end of the url: '?validate_topology=false'\"\n}"}
	to retry, use: --limit @/Users/nallen/tmp/metron-pr1201/metron-deployment/development/centos6/ansible/playbook.retry

PLAY RECAP *********************************************************************
node1                      : ok=76   changed=42   unreachable=0    failed=1

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

@MohanDV
Copy link
Contributor Author

MohanDV commented Sep 19, 2018

@nickwallen It's my bad I dint run this up in Full Dev, I verified my scripts on a 12 node cluster. I did the required changes to support the Full dev deploymwnt and updated the pull request.

@nickwallen
Copy link
Contributor

Can you merge this with master? It is hard to tell what is part of this PR.

@nickwallen
Copy link
Contributor

The configuration elements for PCAP are still under Metron > Configs > REST. Now that you've added stop/start, I think it would make sense to pull those out into its own component/panel, like the other topologies.

screen shot 2018-09-19 at 2 09 18 pm

I was able to spin it up, start the pcap topology, throw some pcap at it, and see it get archived in HDFS, then search for that pcap in the UI. So ya for that!

nickwallen pushed a commit to nickwallen/metron that referenced this pull request Sep 19, 2018
@MohanDV
Copy link
Contributor Author

MohanDV commented Sep 20, 2018

@nickwallen having separate panel for PCAP configs is been addressed in the pull request 1132. It will be a duplicate effort here.

@nickwallen
Copy link
Contributor

@MohanDV ... pull request 1132. It will be a duplicate effort here.

Gotcha. I was not aware of the other PR. That will work.

@nickwallen
Copy link
Contributor

+1 Looks great. Thanks a bunch for the contribution.

@nickwallen
Copy link
Contributor

I want to hold off on the merge until we get the pcap properties change sorted on this. @anandsubbu is opening a re-opening a PR on that.

@anandsubbu
Copy link
Contributor

Hi @nickwallen , I would like to create a fresh pull request based on these changes. Could you go ahead and merge this please ?

@asfgit asfgit closed this in 15194c3 Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants