METRON-2169: Upgrade Kafka/Storm #1453

merrimanr · 2019-07-02T13:44:54Z

Contributor Comments

This PR upgrades Kafka 2.0.0 and Storm to 1.2.0.

Changes Included

Updated Kafka and Storm versions in Maven
Updated Maven pom files to include the correct dependency versions
Updated Maven profile in Ansible to HDP-3.1.0.0
Changed REST classes to use new Kafka client classes
Substituted Kafka constants for hardcoded strings
Upgraded to the KafkaComponent class to use new Kafka classes

Testing

I have done some light testing in full dev including:

Verified all topologies are running with no errors and data is flowing through
Verified the Kafka REST endpoints functions as expected
Verified the Kafka Stellar functions continue to work

Future Work

I believe there are parts of our codebase that we can deprecate in separate PRs:

I also ran into several classpath version errors. It is not possible to resolve these using the standard Maven exclude tags due to the issue described here. As a workaround, I move the conflicting dependency to the top of the pom so that it takes priority over the shaded dependencies. This is not ideal but easier than trying to track the version down in the shaded dependencies.

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

Have you included steps to reproduce the behavior or problem that is being changed or addressed?
Have you included steps or a guide to how the change may be verified and tested manually?
Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
```
Have you written or updated unit tests and or integration tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
```
cd site-book
mvn site
```
Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

mmiklavc

@merrimanr Thanks for the contribution. Can we see what, if any, of the Kafka changes are backwards compatible with master? This is a minor version change - 2.10 to 2.12, so the API should be compatible. This upgrade task has become pretty meaty, and I think we want to get as much of the low-hanging fruit stable against master as possible before finishing out the bigger tasks in the feature branch.

mmiklavc · 2019-08-19T21:39:31Z

metron-platform/metron-integration-test/pom.xml

    <dependency>
      <groupId>org.apache.kafka</groupId>
-      <artifactId>kafka_2.10</artifactId>
+      <artifactId>kafka-clients</artifactId>


I see a change from kafka_2.10 to kafka-clients in a number of places, and in others (see below) there is kafka_2.12. Can you explain this further? Can they all be normalized?

The kafka_2.12 dependency is needed for the Kafka testing infrastructure. That is why it's only used here in metron-integration-test.

mmiklavc · 2019-08-19T21:40:55Z

...-integration-test/src/main/java/org/apache/metron/integration/components/KafkaComponent.java

  @Override
  public void stop() {
-    shutdownConsumer();
    shutdownProducers();


Do we not need to shut down the consumers here any longer?

Not sure why I originally did this. I will add it back.

mmiklavc · 2019-08-19T21:41:23Z

...-integration-test/src/main/java/org/apache/metron/integration/components/KafkaComponent.java

      zkClient.deleteRecursive(ZkUtils.PreferredReplicaLeaderElectionPath());
      zkClient.deleteRecursive(ZkUtils.BrokerSequenceIdPath());
      zkClient.deleteRecursive(ZkUtils.IsrChangeNotificationPath());
-      zkClient.deleteRecursive(ZkUtils.EntityConfigPath());


What's this removed for?

This method no longer exists in the newer version. I don't know what it's for but tests still pass so I assume it isn't needed.

mmiklavc · 2019-08-19T21:45:47Z

...-integration-test/src/main/java/org/apache/metron/integration/components/KafkaComponent.java

-      byte[] bytes = new byte[payload.limit()];
-      payload.get(bytes);
-      messages.add(bytes);
+    ConsumerRecords<byte[], byte[]> records = consumer.poll(Duration.ofSeconds(1));


Are we basing this off of a previous default from Kafka? I can't tell what that might have been from the removed code. If 1 second is indeed reasonable, can this value be made a constant?

I will make this a constant.

mmiklavc · 2019-08-19T21:46:02Z

metron-platform/metron-management/pom.xml

-                </exclusion>
-            </exclusions>
-        </dependency>
+        <!--<dependency>-->


mmiklavc · 2019-08-19T21:51:21Z

metron-platform/metron-solr/metron-solr-common/pom.xml

            </exclusions>
        </dependency>
-        <dependency>
+        <!--dependency>


mmiklavc · 2019-08-19T21:53:10Z

metron-platform/metron-solr/metron-solr-storm/pom.xml

        <commons.config.version>1.10</commons.config.version>
    </properties>
    <dependencies>
-        <dependency>


Can you explain the reason for the deps moving around? I'm assuming this is to deal with some classpath issues, and it's also why this begs the question - anything we do that changes around classpath ordering comes with it risks, and so it should be minimized unless absolutely necessary.

Correct, these changes were to fix classpath issues. Newer dependency versions introduce new transitive dependency versions. Any classpath ordering changes in this PR were necessary.

mmiklavc · 2019-08-19T21:53:18Z

metron-platform/metron-storm-kafka-override/pom.xml

-                </exclusion>
-            </exclusions>
-        </dependency>
+        <!--<dependency>-->


mmiklavc · 2019-08-19T21:57:24Z

...riter/metron-writer-common/src/test/java/org/apache/metron/writer/kafka/KafkaWriterTest.java

    assertEquals(producerConfigs.get("key.serializer"), "org.apache.kafka.common.serialization.StringSerializer");
    assertEquals(producerConfigs.get("value.serializer"), "org.apache.kafka.common.serialization.StringSerializer");
-    assertEquals(producerConfigs.get("request.required.acks"), 1);
+    assertEquals(producerConfigs.get("acks"), "1");


Are these properties exchangeable?

request.required.acks

ProducerConfig.ACKS_CONFIG (which is "acks")

I don't see request.required.acks in the current producer config class, but I do see acks, which means we may be losing a config option here.

I believe this property changed from request.required.acks to acks from version 0.9.x to 0.10.x:

0.9.x - https://kafka.apache.org/090/documentation.html#design_ha
2.0.x - https://kafka.apache.org/20/documentation.html#design_ha

mmiklavc · 2019-08-19T22:00:16Z

pom.xml

+            </activation>
+            <properties>
+                <hdp_version>3.1.0.0</hdp_version>
+                <global_storm_version>1.2.1</global_storm_version>


Can we separate Storm and Kafka? These are not closely related the way ES and Kibana are.

Sure. I don't believe any changes were needed for Storm.

initial commit

91843e6

mmiklavc reviewed Aug 19, 2019

View reviewed changes

merrimanr closed this Aug 20, 2019

This was referenced Aug 20, 2019

METRON-2169: Upgrade Kafka/Storm #1488

Closed

METRON-2169: Upgrade to Kafka 2.0.0 and Storm 1.2.1 #1490

Closed

METRON-2169: Upgrade Kafka/Storm #1453

METRON-2169: Upgrade Kafka/Storm #1453

Uh oh!

Conversation

merrimanr commented Jul 2, 2019

Contributor Comments

Changes Included

Testing

Future Work

Pull Request Checklist

For all changes:

For code changes:

For documentation related changes:

Note:

Uh oh!

mmiklavc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

merrimanr Aug 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

merrimanr Aug 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

merrimanr Aug 20, 2019 •

edited

Loading

merrimanr Aug 20, 2019 •

edited

Loading