METRON-2169: Upgrade to Kafka 2.0.0 and Storm 1.2.1

[merrimanr]

Contributor Comments

This PR upgrades the Kafka client dependency from 0.10.0.1 to 2.0.0 and the Storm dependency from 1.0.3 to 1.2.1. Overall this upgrade was pretty straightforward. The only complex changes involved upgrading the KafkaComponent class to use new Kafka admin and testing classes.

@mmiklavc, all the comments you made on #1453 should be addressed here with the exception of excluding Storm. I had to upgrade both Storm and Kafka versions or I get this.

@nickwallen, all the comments you made on #1488 should be addressed as well.

To isolate Kafka/Storm from the rest of the components, I upgraded these versions independently in all Maven profiles. This will allow us to test newer client versions in full dev without having to upgrade all clients. I created a Jira to reconcile these once we complete the upgrade work.

Testing

Right now I have only verified that it builds and tests pass. I plan on running these tests in full dev:

Verify full dev comes up without error and data is landing in ES
Verify all REST Kafka functions are working as expected
Verify all Stellar Kafka functions are working as expected
Verify Kerberos

Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.

In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:

For all changes:

• Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
• Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
• Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

• Have you included steps to reproduce the behavior or problem that is being changed or addressed?

• Have you included steps or a guide to how the change may be verified and tested manually?

• Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:

  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
  

• Have you written or updated unit tests and or integration tests to verify your changes?

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

• Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:

  cd site-book
  mvn site
  

• Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

[nickwallen]

This is looking really clean. A few feedback items, but I think this is really close.

[merrimanr]

The latest commit fixes this failed test in ProfilerIntegrationTest:

2019-08-23 19:02:50 ERROR executor:0 - 
java.lang.RuntimeException: java.lang.IllegalStateException: This consumer has already been closed.

My guess is that this upgrade changed the behavior of the Kafka Spout to close the consumer when a topology is killed. ProfilerIntegrationTest is unique in that it starts and stops multiple topologies whereas most integration tests (EnrichmentIntegrationTest) only use one. The fix I chose is to remove this step (consumer close) from the KafkaComponent.stop method. The KafkaComponent.shutdownConsumer method is still available if closing the internal client is necessary.

[merrimanr]

I still this error happening intermittently:

2019-08-26 13:50:36 ERROR util:0 - Async loop died!
java.lang.RuntimeException: java.lang.IllegalStateException: This consumer has already been closed.
	at org.apache.storm.utils.DisruptorQueue.consumeBatchToCursor(DisruptorQueue.java:522)
	at org.apache.storm.utils.DisruptorQueue.consumeBatchWhenAvailable(DisruptorQueue.java:487)
	at org.apache.storm.utils.DisruptorQueue.consumeBatch(DisruptorQueue.java:477)
	at org.apache.storm.disruptor$consume_batch.invoke(disruptor.clj:70)
	at org.apache.storm.daemon.executor$fn__4975$fn__4990$fn__5021.invoke(executor.clj:634)
	at org.apache.storm.util$async_loop$fn__557.invoke(util.clj:484)
	at clojure.lang.AFn.run(AFn.java:22)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalStateException: This consumer has already been closed.
	at org.apache.kafka.clients.consumer.KafkaConsumer.acquireAndEnsureOpen(KafkaConsumer.java:2202)
	at org.apache.kafka.clients.consumer.KafkaConsumer.beginningOffsets(KafkaConsumer.java:1984)
	at org.apache.kafka.clients.consumer.KafkaConsumer.beginningOffsets(KafkaConsumer.java:1963)
	at org.apache.storm.kafka.spout.metrics.KafkaOffsetMetric.getValueAndReset(KafkaOffsetMetric.java:79)
	at org.apache.storm.daemon.executor$metrics_tick$fn__4899.invoke(executor.clj:345)

I am able to narrow it down to the FluxTopologyComponent.reset that gets called after every test. I changed this test to call FluxTopologyComponent.stop instead, similar to how other integration tests work. I was able to get through several runs without an error but I will keep testing.

[nickwallen]

Hey @merrimanr - Your test script mentions validating these changes under kerberos. That might not be necessary based on your changes in this PR.

I would suggest that we hold off on validating kerberos until we have all the upgrade work merged into the feature branch. This makes sense to me because (1) we are working on a feature branch and (2) our code doesn't really do much with kerberos, it is just provided by the underlying platform.

[nickwallen]

+1 Thanks @merrimanr . This looks good. I ran this up using the CentOS 7 dev environment. I validated that the topologies consumed telemetry and poked and prodded them by stopping, starting, and rebalancing. I also ensured that I can access Kafka using the KAFKA_* stellar functions. No problems.

[nickwallen]

This has been merged into the feature branch as 15e5276