Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Some Python 3 fixes in ./tools#11672

Merged
marcoabreu merged 3 commits intoapache:masterfrom
cclauss:fix-tools-for-Python3
Jul 13, 2018
Merged

Some Python 3 fixes in ./tools#11672
marcoabreu merged 3 commits intoapache:masterfrom
cclauss:fix-tools-for-Python3

Conversation

@cclauss
Copy link
Copy Markdown
Contributor

@cclauss cclauss commented Jul 12, 2018

Description

Fix undefined names found be flake8 F821 that are mostly (but not exclusively) related to Python 3. Each undefined name has the potential to raise NameError at runtime. Used the six module as discussed at #10833 (comment) Also see #11669

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@cclauss cclauss requested a review from szha as a code owner July 12, 2018 18:30
Copy link
Copy Markdown
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ship tools as part of our package and we should avoid using six as it's not in our dependency.

@marcoabreu marcoabreu merged commit d611037 into apache:master Jul 13, 2018
@cclauss cclauss deleted the fix-tools-for-Python3 branch July 13, 2018 08:36
import math
import sys

from mxnet.base import xrange
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? We don't have xrange definition in mxnet.base. My approval doesn't apply to this change.

szha pushed a commit to szha/mxnet that referenced this pull request Jul 13, 2018
@cclauss
Copy link
Copy Markdown
Contributor Author

cclauss commented Jul 13, 2018

Sorry. This comment #11671 (review) got me messed up.

@szha
Copy link
Copy Markdown
Member

szha commented Jul 13, 2018

@cclauss no worries. You can reopen a PR to make the proper change after revert.

@cclauss
Copy link
Copy Markdown
Contributor Author

cclauss commented Jul 13, 2018

OK. Thanks.

szha added a commit that referenced this pull request Jul 13, 2018
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
* Some Python 3 fixes in ./tools

* Do not use six

* from mxnet.base import xrange
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants