This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Some Python 3 fixes in ./tools again#11757
Merged
szha merged 1 commit intoapache:masterfrom Jul 18, 2018
cclauss:fix-tools-for-Python3-again
Merged
Some Python 3 fixes in ./tools again#11757szha merged 1 commit intoapache:masterfrom cclauss:fix-tools-for-Python3-again
szha merged 1 commit intoapache:masterfrom
cclauss:fix-tools-for-Python3-again
Conversation
szha
approved these changes
Jul 14, 2018
KellenSunderland
pushed a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Jul 19, 2018
KellenSunderland
pushed a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Jul 21, 2018
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A second shot at #11672 but with from six.moves import xrange.
Fix undefined names found be flake8 F821 that are mostly (but not exclusively) related to Python 3. Each undefined name has the potential to raise NameError at runtime. Used the six module as discussed at #10833 (comment) Also see #11669
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments