[WIP]Change mshadow shape size to size_t#13729
[WIP]Change mshadow shape size to size_t#13729ZhennanQin wants to merge 6 commits intoapache:masterfrom
Conversation
|
@apeforest why mshadow::Shape::size() returns index_t instead of size_t? This will cause trouble when comparing it with other size() returns. Just as this CI failed. Any reason we need negative for this? |
|
dmlc/mshadow#359 this PR introduces this issue. |
|
@ZhennanQin In MXNet code, we have many for loop with the type of indexing variable |
|
@apeforest CI can pass after changing back to return size_t. The corresponding MXNet change are shown as this PR. If this solution is OK. I will file separate PR to mshadow. |
|
LGTM, thanks a lot for your help. Please update the PR title and description when it's ready for review. Thanks |
|
@apeforest mshadow PR is created at dmlc/mshadow#367, please help to merge it. Then I will edit this PR. Thanks. |
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments