Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[WIP]Change mshadow shape size to size_t#13729

Closed
ZhennanQin wants to merge 6 commits intoapache:masterfrom
ZhennanQin:ci
Closed

[WIP]Change mshadow shape size to size_t#13729
ZhennanQin wants to merge 6 commits intoapache:masterfrom
ZhennanQin:ci

Conversation

@ZhennanQin
Copy link
Copy Markdown
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ZhennanQin
Copy link
Copy Markdown
Contributor Author

@apeforest why mshadow::Shape::size() returns index_t instead of size_t? This will cause trouble when comparing it with other size() returns. Just as this CI failed. Any reason we need negative for this?

@pengzhao-intel
Copy link
Copy Markdown
Contributor

@zheng-da

@ZhennanQin
Copy link
Copy Markdown
Contributor Author

dmlc/mshadow#359 this PR introduces this issue.

@sandeep-krishnamurthy sandeep-krishnamurthy added Backend Issues related to the backend of MXNet pr-work-in-progress PR is still work in progress labels Dec 26, 2018
@apeforest
Copy link
Copy Markdown
Contributor

@ZhennanQin In MXNet code, we have many for loop with the type of indexing variable i to be index_t. If the size return type is size_t, we would need to add static cast to all the for loops.

@ZhennanQin ZhennanQin requested a review from szha as a code owner December 28, 2018 01:20
@ZhennanQin
Copy link
Copy Markdown
Contributor Author

@apeforest CI can pass after changing back to return size_t. The corresponding MXNet change are shown as this PR. If this solution is OK. I will file separate PR to mshadow.

Comment thread src/operator/convolution_v1-inl.h Outdated
@apeforest
Copy link
Copy Markdown
Contributor

LGTM, thanks a lot for your help. Please update the PR title and description when it's ready for review. Thanks

@ZhennanQin
Copy link
Copy Markdown
Contributor Author

@apeforest mshadow PR is created at dmlc/mshadow#367, please help to merge it. Then I will edit this PR. Thanks.

@ZhennanQin ZhennanQin changed the title [Don't merge] check CI Change mshadow shape size to size_t Jan 3, 2019
@ZhennanQin ZhennanQin changed the title Change mshadow shape size to size_t [WIP]Change mshadow shape size to size_t Jan 3, 2019
@ZhennanQin ZhennanQin closed this Jan 17, 2019
@ZhennanQin ZhennanQin deleted the ci branch September 16, 2019 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Backend Issues related to the backend of MXNet pr-work-in-progress PR is still work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants