This repository was archived by the owner on Aug 11, 2020. It is now read-only.
Re-Revert PR #348 to support large tensor size in MXNet#359
Merged
szha merged 7 commits intodmlc:masterfrom Oct 4, 2018
Merged
Re-Revert PR #348 to support large tensor size in MXNet#359szha merged 7 commits intodmlc:masterfrom
szha merged 7 commits intodmlc:masterfrom
Conversation
Contributor
Author
apeforest
changed the title
Member
|
Please open a PR in MXNet and show that this can be merged this without problems, w/ your fork of mshadow. |
Contributor
Author
|
@szha The PR in MXNet with this patch is also ready for review: apache/mxnet#11742 Thanks! Lin |
Member
|
The downstream verification looks good to me. Thanks |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to patch a previous reverted PR #348 due to a build failure in MXNet.
This change is to fix the integer overflow issue in MXNet when a large tensor is created and converted to numpy. The related PR (apache/mxnet#11742) in MXNet is pending this dependency to be merged.