Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

v1.3.x - backport leiningen dependency problem#14163

Merged
marcoabreu merged 1 commit intoapache:v1.3.xfrom
perdasilva:fix_deploy
Feb 14, 2019
Merged

v1.3.x - backport leiningen dependency problem#14163
marcoabreu merged 1 commit intoapache:v1.3.xfrom
perdasilva:fix_deploy

Conversation

@perdasilva
Copy link
Copy Markdown
Contributor

Description

Cherry picks fix from #14132 into v1.3.x branch

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@perdasilva perdasilva requested a review from szha as a code owner February 14, 2019 12:21
@perdasilva
Copy link
Copy Markdown
Contributor Author

@gigasquid @marcoabreu

…pache#14132)

The document generation tool - this will ping the version to 2.8.3
@marcoabreu marcoabreu merged commit 8dcc1f6 into apache:v1.3.x Feb 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants