This repository was archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] ONNX contrib_box_nms #19755
Merged
[v1.x] ONNX contrib_box_nms #19755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Zha0q1 , Thanks for submitting the PR
CI supported jobs: [edge, clang, miscellaneous, windows-cpu, windows-gpu, website, centos-cpu, unix-gpu, unix-cpu, sanity, centos-gpu] Note: |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
josephevans
reviewed
Jan 16, 2021
| out_names = list() | ||
| for name in sym.list_outputs(): | ||
| if name.endswith('_output'): | ||
| if re.search('.*_output$', name): |
Contributor
There was a problem hiding this comment.
Why use a regex here? endswith would be more efficient.
| if name.endswith('_output'): | ||
| if re.search('.*_output$', name): | ||
| out_names.append(name[:-len('_output')]) | ||
| elif re.search('.*_output[0-9]$', name): |
Contributor
There was a problem hiding this comment.
Instead of using a regex here, you could just check for output in the string, like:
if name[-len('output0'):-1] == 'output':
Contributor
Author
|
@josephevans thanks for reviewing, will change. Additionally I need to fix the graph linking issue when a node have > 1 output, thus adding [wip] |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-work-in-progress
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
box nms op
currently does not support
id_indexandbackground_id-- we can add those later if requested