Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@josephevans
Copy link
Contributor

Fix broken link for download of v1.8.0 source version.

Change link to file archive name for link (instead of just "Download") and change links for pgp/sha512 checksum files to "asc" and "sha512" to be more clear.

Per feedback from Apache 1.9 release thread: https://lists.apache.org/thread/2lbd5mbv32b50mvok0t7j0svss55xjtm

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, centos-cpu, windows-gpu, sanity, windows-cpu, miscellaneous, edge, clang, unix-gpu, website, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Dec 23, 2021
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@szha
Copy link
Member

szha commented Dec 23, 2021

Once merged, let's have this change on 1.X and master branches too

@mseth10 mseth10 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 24, 2021
@josephevans josephevans merged commit 72a3082 into apache:v1.9.x Dec 24, 2021
@josephevans josephevans deleted the v1.9.x_fix_download_links branch December 24, 2021 00:11
josephevans added a commit to josephevans/mxnet that referenced this pull request Dec 24, 2021
josephevans added a commit to josephevans/mxnet that referenced this pull request Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-merge Review and CI is complete. Ready to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants