Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Update website version dropdown on master#9901

Merged
marcoabreu merged 2 commits intoapache:masterfrom
marcoabreu:fix-website2
Feb 27, 2018
Merged

Update website version dropdown on master#9901
marcoabreu merged 2 commits intoapache:masterfrom
marcoabreu:fix-website2

Conversation

@marcoabreu
Copy link
Copy Markdown
Contributor

Update website version dropdown on master

@marcoabreu marcoabreu requested a review from szha as a code owner February 27, 2018 16:48
@marcoabreu
Copy link
Copy Markdown
Contributor Author

Self merge due to release blocker

@marcoabreu marcoabreu merged commit 6005ad5 into apache:master Feb 27, 2018
then
total=${#tag_list[*]}
for (( i=0; i<=$(( $total -1 )); i++ ))
for (( i=0; i<=$(( $total - 1 )); i++ ))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really strange way to do a loop condition. Usually you would do i < $total, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, legacy :D

@marcoabreu marcoabreu deleted the fix-website2 branch March 21, 2018 15:14
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* Update website version dropdown on master

* Update
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* Update website version dropdown on master

* Update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants