Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Update website version dropdown on master #9901

Merged
marcoabreu merged 2 commits into from
Feb 27, 2018
Merged

Update website version dropdown on master #9901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e4068d
Update website version dropdown on master
marcoabreu Feb 27, 2018
74df8bf
Update
marcoabreu Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/build_version_doc/build_doc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,13 @@ fi
if [ $latest_tag != ${tag_list[0]} ]
then
total=${#tag_list[*]}
for (( i=0; i<=$(( $total -1 )); i++ ))
for (( i=0; i<=$(( $total - 1 )); i++ ))
Copy link
Copy Markdown
Contributor

@lebeg lebeg Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really strange way to do a loop condition. Usually you would do i < $total, right?

Copy link
Copy Markdown
Contributor Author

@marcoabreu marcoabreu Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, legacy :D


do
tests/ci_build/ci_build.sh doc python docs/build_version_doc/AddVersion.py --file_path "$web_folder/versions/${tag_list[$i]}" \
--current_version "${tag_list[$i]}"
done

# Update master version dropdown
tests/ci_build/ci_build.sh doc python docs/build_version_doc/AddVersion.py --file_path "$web_folder/versions/master"
fi