Rich HTML UI for (now only for) VSCode Refactorings #3349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into jtulach/WebViews
…e the refactoring UI also works in NetBeans
JaroslavTulach
added
work-in-progress
API Change
JaroslavTulach
commented
Dec 6, 2021
.../src/org/netbeans/modules/java/lsp/server/refactoring/ChangeMethodParametersRefactoring.java
Show resolved
Hide resolved
JaroslavTulach
force-pushed
the
jtulach/WebViews
branch
from
c25e84e to
1244c27
Compare
added 5 commits
December 8, 2021 18:34
…e it to Maven central
JaroslavTulach
commented
Dec 9, 2021
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/htmlui/Browser.java
Show resolved
Hide resolved
added 4 commits
December 9, 2021 04:43
… show the HTML UI only, when supported
Author
|
Opps, I wanted to create a new PR, but instead I integrated 9e27e19 into We don't have a way to remove commit from |
Member
Aside - it happens! 😄 I've long been in the habit of using |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the prototyping work we (Jirka Sedláček, Dušan Bálek and me) have done to make sure Rich UI for Change Parameters Refactoring can be productized. All changes were squashed and integrated by #3357 and #3361. This PR is now closed, but holds history of individual commits and few changes showing how to use and test the HTML UI in classical NetBeans IDE.
By default VSCode UI follows principles of asceticism and is very simplistic and straightforward. It is possible to use
WebViewfor more complex UIs, but:Anyway we really need it for the refactoring and we made it. Here is the result:
My goal is to get this into January version of NetBeans and its VSCode extension. That requires fixes in HTML/Java API, some API fixes in NetBeans itself and then implementation of the refactoring. Those changes were done by #3357 and #3361.
The remaining (unmerged) part of this PR demonstrates how to use the HTML UI in NetBeans. It adds two actions into refactoring menu:
The first action opens dialog with the same Change Method Parameters Refactoring UI as provided to VSNetBeans by #3361 in a dialog - e.g. it shows sharing of the HTML UI is possible among the Swing and Electron based flavors of the IDE. Second Open HTML Hello World! action opens a top component with wizard generated sample
showing input line and a button that opens a dialog. I used this example to test that interaction between HTML, Swing and JavaFX works unchanged when refactoring the code in #3357
Cons: I haven't yet convinced JavaFX WebView to load
codicons.cssandcodeicons.ttfas provided by #3361 - as such the HTML UI in NetBeans isn't as slick. Further enhancements into the JavaFX webview integration are needed.