Updating HTML/Java API to 1.7.3 version #3357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
dbalek,
lkishalmi,
matthiasblaesing,
neilcsmith-net and
sdedic
added 5 commits
December 7, 2021 19:20
dbalek
approved these changes
Dec 8, 2021
Contributor
dbalek
left a comment
dbalek
left a comment
There was a problem hiding this comment.
Proposed API looks fine to me.
lkishalmi
approved these changes
Dec 8, 2021
Contributor
lkishalmi
left a comment
lkishalmi
left a comment
There was a problem hiding this comment.
Well, skimming through, I've not found anything wrong with this.
neilcsmith-net
approved these changes
Dec 8, 2021
Member
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
As with @lkishalmi I have only skimmed through. Seems a good idea. I would happily see the back of all HTML dialogs in the IDE though!
JaroslavTulach
pushed a commit
to JaroslavTulach/netbeans
that referenced
this pull request
Dec 8, 2021
This was referenced Dec 9, 2021
JaroslavTulach
pushed a commit
to JaroslavTulach/netbeans
that referenced
this pull request
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML/Java API has recently released its 1.7.3 version which (among other) gives proper OSGi bundle names to its modules. Former
genericmodule is noworg.netbeans.html.presenters.spi. Time to upgrade.When at it, I am also splitting the
api.htmluimodule to two parts. The goal is to move the JavaFX WebView based implementation into its own module and allow the API to be used without it. That's all built aroundHTMLViewerSpiinterface. 40f460e adds a fallback implementation of the SPI interface that warns the user gracefully.Also, to satisfy old @dbalek request, I am introducing
OnSubmitcallback that, allows validation of the state of the dialog before it is closed.The commit c182fc3 modifies
nbjunitmodule. I tried to useMockServicesin TestNG without depending on JUnit4 and was getting linkage errors. Replacing the exceptions withjava.lang.AssertionErrorfixes the problems.This PR is the first in a line of others. The ultimate goal is to get Rich HTML UI for (now only for) VSCode Refactorings as outlined in #3349 into NetBeans and its VSCode extension.