Dependency Update Checker Workflow#6927
Merged
mbien merged 1 commit intoapache:masterfrom Jan 12, 2024
Merged
Conversation
2f69711 to
98b253d
Compare
Maven dependency update hint analog, but for binaries-list files and put into a workflow.
lkishalmi
approved these changes
Jan 12, 2024
Contributor
lkishalmi
left a comment
There was a problem hiding this comment.
Looks good. The only thing, that instead of throwing a RuntimeException on errors, I'd just log a one liner, so the process would continue, instead of failing fast.
Member
Author
|
@lkishalmi my thought was that someone who is running the script via actions or locally, would probably restart it anyway if there are networking issues. If this happens to be a problem, we could add a retry loop there and then fail after 3 retries or so. It is manually triggered, it won't run automatically in PRs or so that is why I think fail-fast is better there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven dependency update hint analog, but for
binaries-listfiles and put into a workflow. I used the util already for PRs like #6918 and thought this would have greater value when run by CI so others can use it too.output looks like:
see job summary or log for full output:
https://github.com/apache/netbeans/actions/runs/7442427492
workflow is currently configured to run only on manual dispatch (this will only work once merged to master). This means that it can be manually triggered from https://github.com/apache/netbeans/actions/workflows/dependency-checks.yml
btw: the very first version of this util generated temporary pom files for each module containing binaries-list and then ran
mvn verify versions:display-dependency-updates, this is the more direct approach without extra steps which download half of the internet.