Conversation
- #6980 - Fix the below case - Add unit tests Example: ```php <?php namespace { use Vendor\Class1; $test = 1; } ``` Before: ```php <?php namespace { use Vendor\Class1; $test = 1; } ``` After: ```php <?php namespace { use Vendor\Class1; $test = 1; } ```
Fix incorrect formatting after use statements #6980
…essage PHP: Implemented display of exception message when exception breakpoints are hit
- Get aliased names for traits and enums - Add unit tests
- #6947 - Add `Auto Import` as an option for code completion - Add `Prefer Import` and `Don't Import` options for global namespace items(`Don't Import` is enabled by default) - `File Scope` means a php file without a namespace name (e.g. `<html><p><?php echo \NS\something(); ?></p></html>`) - Add `File Scope`(unchecked by default) and `Namespace Scope`(checked by default) options - Don't add a use statement if use list has the same name item(Instead, the result of "Smart" or "Unqualified" CC is used) - Add unit tests Note: A use statement may not be added to an expected position if the existing use list is not sorted(ignore cases)
Add the Auto Import feature for Code Completion
- #7041 - Don't add parameter parts if the context is use functions - Add unit tests
…nction Fix incorrect code completion for use function #7041
Member
|
@junichi11 when are you planning to merge this? I would like to get a larger cleanup PR in without causing conflicts. |
Member
Author
|
@mbien I'll do that ASAP :) |
tmysik
approved these changes
Feb 21, 2024
Member
tmysik
left a comment
tmysik
left a comment
There was a problem hiding this comment.
I guess we are only merging branch with already reviewed changes, right?
Member
Author
|
@tmysik Yes, thanks! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These already have been reviewed.