Fix parsing of JDK 17+ Javadoc of methods without HTML a tags.#7833
Fix parsing of JDK 17+ Javadoc of methods without HTML a tags.#7833t-gergely wants to merge 1 commit intoapache:masterfrom
Conversation
|
Linking with #5127 Thanks for this. I think makes sense, but I can't remember the reason I marked state as a_open. Possibly also me not fully understanding the quirks of the state engine! 😄 Hopefully this change doesn't break anything elsewhere. Parsing with a HTML 3.2 parser is becoming more problematic! It would be good to generate test files for Javadoc 21+ alongside the ones introduced in the other PR. The source files are there. If you felt like adding that to this, that would be a great addition and way to prove your change! |
There was a problem hiding this comment.
Hi, thanks for the contribution, but we require a valid email address in the commit header, you can check it by looking at the patch file of this PR: https://github.com/apache/netbeans/pull/7833.patch
feel free to force push into this PR once fixed
(we might merge #6630 one day so that CI checks things like that automatically)
Yes, it was a bad idea to post this PR. Sorry. I probably should have attached a patch to an issue instead. You may commit the patch yourselves: I don't take credit for anything in it.
I don't see a good reason for that. OTOH methods |
|
@t-gergely could you please check the comment from @mbien? |
I think I've already replied to that. |
NetBeans didn't show Javadoc descriptions for a lot of OpenJDK (21) methods. This simple patch works for me, but feel free to drop this PR, and fix the bug whatever way you like.