Skip to content

Fix parsing of JDK 17+ Javadoc of methods without HTML a tags. #7833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
t-gergely wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix parsing of JDK 17+ Javadoc of methods without HTML a tags. #7833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/java.sourceui/src/org/netbeans/api/java/source/ui/HTMLJavadocParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ public void handleSimpleTag(HTML.Tag t, MutableAttributeSet a, int pos) {
String attrId = (String) a.getAttribute(HTML.Attribute.ID);
if (names.contains(attrId)) {
// we have found desired javadoc member info anchor
state[0] = A_OPEN;
state[0] = A_CLOSE;
}
} else {
section_counter++;
Expand Down
8 changes: 6 additions & 2 deletions java/java.sourceui/test/unit/src/org/netbeans/api/java/source/ui/HTMLJavadocParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/
package org.netbeans.api.java.source.ui;

import java.net.MalformedURLException;
import java.net.URI;
import java.net.URL;
import java.net.URLEncoder;
Expand Down Expand Up @@ -83,7 +82,12 @@ public void testJavadoc17Class() throws Exception {
assertTrue(result.contains("This is an example class."));
assertFalse(result.contains("</section>"));

URL url = appendFragment(root, "<init>(java.lang.String)");
URL url = appendFragment(root, "<init>()");
result = HTMLJavadocParser.getJavadocText(url, false);
assertTrue(result.contains("This is the default constructor."));
assertFalse(result.contains("</section>"));

url = appendFragment(root, "<init>(java.lang.String)");
result = HTMLJavadocParser.getJavadocText(url, false);
assertTrue(result.contains("This is a constructor taking a single String parameter."));
assertFalse(result.contains("</section>"));
Expand Down