Set javadoc 23 specific flags only on JDK 23 and later#8152
Merged
mbien merged 1 commit intoapache:masterfrom Jan 23, 2025
Merged
Set javadoc 23 specific flags only on JDK 23 and later#8152mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
mbien
force-pushed
the
set-line-doc-flag-only-on-23
branch
from
b9e9891 to
1cc1873
Compare
mbien
force-pushed
the
set-line-doc-flag-only-on-23
branch
from
1cc1873 to
2aa0bb4
Compare
Contributor
|
release build is fixed to build on what json tell but anyone could build with jdk 17 and not be aware to use different jdk for apidoc, |
ebarboni
approved these changes
Jan 17, 2025
Member
Author
|
@ebarboni should I link this to the issue and merge or is there more what needs to be done? |
Contributor
|
You can link and merge. Issue is a bit multifactor, template was not backward compatible, but the build was a bit dangerous using the baseline jdk for both build and javadoc instead of the one specified in json. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to #7907
javadoc-exec-filesandjavadoc-exec-packages(first was overlook last time)might help with #8128 (not sure if it fixes it, would need verification)