Disable JDK 23 line-doc comments for now#7907
Merged
ebarboni merged 1 commit intoapache:deliveryfrom Nov 5, 2024
Merged
Conversation
- codebase has many occurrences of '///' which were never meant to appear in javadoc this disables JDK 23+ "line doc comments" for now - javadoc CI step should run on JDK 23
mbien
added
CI
matthiasblaesing
approved these changes
Oct 24, 2024
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Makes sense to me. Thank you.
lahodaj
approved these changes
Oct 29, 2024
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Thanks!
This was referenced Jan 10, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lists about 1k files, this would be too much work to clean up for little gain atm
targets delivery