Conversation
mbien
added
CI
mbien
commented
Jul 4, 2025
Comment on lines
282
to
285
| <mkdir dir="${javadoc.out.dir}/resources"/> | ||
| <mkdir dir="${javadoc.out.dir}/resource-files/resources"/> | ||
| <copy file="${javadoc.out.dir}/resource-files/glass.png" todir="${javadoc.out.dir}/resource-files/resources" /> | ||
| <copy file="${javadoc.out.dir}/resource-files/x.png" todir="${javadoc.out.dir}/resource-files/resources" /> |
Member
Author
Member
Author
There was a problem hiding this comment.
updated the PR, it copies now the SVGs on JDK 25.
Member
Author
|
for those wondering, the |
Member
Author
|
planning to merge this soon |
Contributor
|
LGTM, pass on jdk 25 (build 30) |
ebarboni
approved these changes
Jul 8, 2025
- JDK javadoc icons switched from png to svg minor cleanup - no need to disable linedoc anymore since dangling comment warnings were fixed - remove unused dependency
Member
Author
|
cool thanks for review, will rebase and then merge (once green)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
minor cleanup